Repository navigation
Commit 8b380b9
committed
🐛 Let the workflow host answer its own <Elicit> through the CLI (#607)
Whether an execution activates the testing stack and whether this host owns
elicitation are two decisions, and the CLI made them as one: every non-testing
document got the Web provider. A workflow start is a non-testing document, so
the provider landed in the nested document scope inside the host's attachment —
nearer, at the same `{ at: "min" }`, and therefore first. A workflow reaching
`<Elicit>` opened a loopback form and waited for a reader who is not coming
instead of committing a `suspension_request` and settling `suspended`.
`DocumentMode` now carries a required `webElicitation`, and each trusted profile
states it: `xmd run` and the nested `host="run"` profile enable it, `xmd test`
and `xmd workflow` do not. Required rather than defaulted, so a profile added
later cannot inherit the browser form by omission. `installWebComponents()`
stays unconditional — an authored `<WebForm>` under a workflow still asks
through its own component.
The regression launches the real Deno-source CLI, because no in-process caller
builds the assembly that was broken: `runWorkflow()` and `executeInstalled()`
both skip it. Before the fix the case is abandoned at its deadline with
`http://127.0.0.1:<port>/f/…` on the captured channel.1 parent 170a021 commit 8b380b9
3 files changed
Lines changed: 167 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
572 | 572 | | |
573 | 573 | | |
574 | 574 | | |
| 575 | + | |
| 576 | + | |
| 577 | + | |
| 578 | + | |
| 579 | + | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
| 586 | + | |
575 | 587 | | |
576 | 588 | | |
577 | 589 | | |
| |||
628 | 640 | | |
629 | 641 | | |
630 | 642 | | |
631 | | - | |
| 643 | + | |
| 644 | + | |
| 645 | + | |
632 | 646 | | |
633 | 647 | | |
634 | | - | |
635 | | - | |
636 | | - | |
637 | | - | |
| 648 | + | |
| 649 | + | |
| 650 | + | |
| 651 | + | |
| 652 | + | |
| 653 | + | |
| 654 | + | |
| 655 | + | |
638 | 656 | | |
639 | 657 | | |
640 | 658 | | |
| |||
930 | 948 | | |
931 | 949 | | |
932 | 950 | | |
933 | | - | |
| 951 | + | |
| 952 | + | |
| 953 | + | |
934 | 954 | | |
935 | 955 | | |
936 | 956 | | |
| |||
970 | 990 | | |
971 | 991 | | |
972 | 992 | | |
973 | | - | |
| 993 | + | |
974 | 994 | | |
975 | 995 | | |
976 | 996 | | |
| |||
1696 | 1716 | | |
1697 | 1717 | | |
1698 | 1718 | | |
| 1719 | + | |
| 1720 | + | |
| 1721 | + | |
1699 | 1722 | | |
1700 | 1723 | | |
1701 | 1724 | | |
| |||
1832 | 1855 | | |
1833 | 1856 | | |
1834 | 1857 | | |
1835 | | - | |
| 1858 | + | |
| 1859 | + | |
| 1860 | + | |
| 1861 | + | |
| 1862 | + | |
| 1863 | + | |
| 1864 | + | |
| 1865 | + | |
| 1866 | + | |
| 1867 | + | |
| 1868 | + | |
1836 | 1869 | | |
1837 | 1870 | | |
1838 | 1871 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
96 | | - | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
97 | 99 | | |
98 | 100 | | |
99 | 101 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
25 | 30 | | |
26 | 31 | | |
27 | 32 | | |
28 | 33 | | |
| 34 | + | |
29 | 35 | | |
30 | 36 | | |
31 | 37 | | |
| |||
1462 | 1468 | | |
1463 | 1469 | | |
1464 | 1470 | | |
| 1471 | + | |
| 1472 | + | |
| 1473 | + | |
| 1474 | + | |
| 1475 | + | |
| 1476 | + | |
| 1477 | + | |
| 1478 | + | |
| 1479 | + | |
| 1480 | + | |
| 1481 | + | |
| 1482 | + | |
| 1483 | + | |
| 1484 | + | |
| 1485 | + | |
| 1486 | + | |
| 1487 | + | |
| 1488 | + | |
| 1489 | + | |
| 1490 | + | |
| 1491 | + | |
| 1492 | + | |
| 1493 | + | |
| 1494 | + | |
| 1495 | + | |
| 1496 | + | |
| 1497 | + | |
| 1498 | + | |
| 1499 | + | |
| 1500 | + | |
| 1501 | + | |
| 1502 | + | |
| 1503 | + | |
| 1504 | + | |
| 1505 | + | |
| 1506 | + | |
| 1507 | + | |
| 1508 | + | |
| 1509 | + | |
| 1510 | + | |
| 1511 | + | |
| 1512 | + | |
| 1513 | + | |
| 1514 | + | |
| 1515 | + | |
| 1516 | + | |
| 1517 | + | |
| 1518 | + | |
| 1519 | + | |
| 1520 | + | |
| 1521 | + | |
| 1522 | + | |
| 1523 | + | |
| 1524 | + | |
| 1525 | + | |
| 1526 | + | |
| 1527 | + | |
| 1528 | + | |
| 1529 | + | |
| 1530 | + | |
| 1531 | + | |
| 1532 | + | |
| 1533 | + | |
| 1534 | + | |
| 1535 | + | |
| 1536 | + | |
| 1537 | + | |
| 1538 | + | |
| 1539 | + | |
| 1540 | + | |
| 1541 | + | |
| 1542 | + | |
| 1543 | + | |
| 1544 | + | |
| 1545 | + | |
| 1546 | + | |
| 1547 | + | |
| 1548 | + | |
| 1549 | + | |
| 1550 | + | |
| 1551 | + | |
| 1552 | + | |
| 1553 | + | |
| 1554 | + | |
| 1555 | + | |
| 1556 | + | |
| 1557 | + | |
| 1558 | + | |
| 1559 | + | |
| 1560 | + | |
| 1561 | + | |
| 1562 | + | |
| 1563 | + | |
| 1564 | + | |
| 1565 | + | |
| 1566 | + | |
| 1567 | + | |
| 1568 | + | |
| 1569 | + | |
| 1570 | + | |
| 1571 | + | |
| 1572 | + | |
| 1573 | + | |
| 1574 | + | |
| 1575 | + | |
| 1576 | + | |
| 1577 | + | |
| 1578 | + | |
| 1579 | + | |
| 1580 | + | |
| 1581 | + | |
| 1582 | + | |
| 1583 | + | |
| 1584 | + | |
| 1585 | + | |
| 1586 | + | |
| 1587 | + | |
0 commit comments