Repository navigation
Commit 82460bc
committed
π Read every workflow option's value as a value (#818)
The review Plugin decides whether a `workflow` command line executes a document
by finding the action, and the action is the first positional after `workflow` β
the first token that is neither an option nor an option's value. The scan
stepped over four options that take a separated value and missed two.
`--output` and `--status` are the two, and `xmd workflow --output start export
run-1` is what that costs: `--output` takes `start`, the action is `export`, and
a scan that read the first recognized word installed the review graph for a
command that executes no document.
The list is now every non-boolean field of the command's own grammar β `--id`,
`--at`, `--status`, `--artifact`, `--output` β plus the two options read out of
argv before that grammar exists, `--plugin` and the aggregate and generated root
properties. The boolean switches take no value and are skipped as the options
they are. It is written out here because the CLI depends on this package rather
than the other way round, and the comment names the grammar it mirrors.
The regression walks every one of those options with an executing action's own
name as its value and a management action after it, adds the assigned spelling,
and keeps four executing classifications to show the same reading still finds a
real action written after an option.1 parent 0a4f45c commit 82460bc
2 files changed
Lines changed: 57 additions & 25 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
436 | 436 | | |
437 | 437 | | |
438 | 438 | | |
439 | | - | |
440 | | - | |
441 | | - | |
442 | | - | |
443 | | - | |
444 | | - | |
445 | | - | |
446 | | - | |
447 | | - | |
448 | | - | |
449 | | - | |
450 | | - | |
451 | | - | |
452 | | - | |
453 | | - | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
454 | 460 | | |
455 | | - | |
456 | | - | |
457 | | - | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
458 | 475 | | |
459 | 476 | | |
460 | 477 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
44 | 52 | | |
45 | | - | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
46 | 61 | | |
47 | 62 | | |
48 | 63 | | |
| |||
0 commit comments