Repository navigation
Commit 67a8c76
committed
🧪 Tear down a cancelled transport, and stop printing tokens
Review of 6ce7173. The findings that do not depend on the blocked credential
channel.
**A cancelled transport now actually tears down.** Blocking the loopback remote
after it accepted the credential — rather than suspending before `git()` — put
a real Git child with a live authenticated connection under the halt, and it
hung. Native Git runs its transport in `git-remote-http`, a grandchild that
inherits this host's pipes, so signalling only the process XMD spawned left the
helper holding them open and the `close` that teardown waits on never arrived.
Each command now runs in a process group of its own and cancellation signals
the group. The test that found it asserts the remote accepted a request, one
session opened and one disposed, nothing retained, and a fresh acquisition
afterwards.
**Teardown is observed, not scanned for.** A prefix scan of the temporary
directory is a claim about the whole machine, and two concurrent invocations
would each see the other's. Sessions report their own working directories, and
the suite watches the invocation it started.
**No assertion prints a credential-shaped value.** Both precedence tests now map
each token to an opaque source label and compare the label, so a failure says
which source answered rather than what it answered with.
**Replay reaches no session.** A completed `<PullRequest>` replays over a source
whose `open()` throws, and never opens one.
Blocked, and reported separately rather than worked around again: the HTTP
credential channel (finding 1) and the classification and exact-locator evidence
that depend on it (2 and 3). Git offers no opaque-capability channel to a native
subprocess, so a broker lease cannot reach it without a mechanism no settled
document specifies. Findings 5's crash fixture and host-assembly regression
remain open.
Refs #5221 parent 6ce7173 commit 67a8c76
5 files changed
Lines changed: 273 additions & 93 deletions
File tree
- packages/workflow
- src/deno/composition
- tests
- support
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
242 | 242 | | |
243 | 243 | | |
244 | 244 | | |
| 245 | + | |
245 | 246 | | |
246 | 247 | | |
247 | 248 | | |
| 249 | + | |
248 | 250 | | |
249 | 251 | | |
| 252 | + | |
250 | 253 | | |
251 | 254 | | |
252 | 255 | | |
| |||
335 | 338 | | |
336 | 339 | | |
337 | 340 | | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
338 | 355 | | |
339 | 356 | | |
340 | 357 | | |
| 358 | + | |
341 | 359 | | |
342 | 360 | | |
343 | 361 | | |
| |||
351 | 369 | | |
352 | 370 | | |
353 | 371 | | |
| 372 | + | |
354 | 373 | | |
355 | 374 | | |
356 | 375 | | |
| |||
374 | 393 | | |
375 | 394 | | |
376 | 395 | | |
377 | | - | |
| 396 | + | |
378 | 397 | | |
379 | 398 | | |
380 | 399 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
| |||
46 | 47 | | |
47 | 48 | | |
48 | 49 | | |
49 | | - | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
50 | 58 | | |
51 | 59 | | |
52 | 60 | | |
| |||
70 | 78 | | |
71 | 79 | | |
72 | 80 | | |
73 | | - | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
74 | 91 | | |
75 | 92 | | |
76 | 93 | | |
| |||
0 commit comments