Skip to content

Commit 5c1edd0

Browse files
tarastaras
committed
🧪 Revise one pull request, and continue through what was admitted
Both prerequisites landed, so the two scenarios that recorded where the composition stopped now record that it goes all the way through. AC3 is the #588 acceptance. The supervised loop runs two full iterations: the implementor proposes, the change is admitted and committed, the branch is published, a pull request is opened, the planner fails its review, the implementor revises in the same session, and the second publication advances the branch it already published. Both Push records are `performed`; the second retains the predecessor it advanced over and the `ancestor` relation that made advancing an advance rather than a replacement. Each publication is one exact non-force refspec, no upstream tracking is touched, and nothing fetched, reset, merged or rebased to make it apply. The numbered pass looks the pull request up and brings it up to date rather than asking for a second one to exist, standing on this iteration's Push evidence — its retained head is the second commit, never the first. AC4 is the #589 acceptance. The exact retained reviews, comments and checks still reach both the reviewing planner's prompt and the material the checkpoint assesses, byte for byte. What is new is the other half: the run waits at the authored checkpoint, the typed answer is delivered out of band and performs nothing, and an explicit resume completes. The retained sequence is continued rather than rewritten — the generated admission, the write its fragment performed, the effects after it and the wait stand in authored order, and the continuation only appends the answer it spends and the one turn left to take. Nothing completed runs twice, and the whole continuation makes zero forge calls. One fixture correction came with them. The GitHub model froze a created pull request's head at the commit its creation resolved, so it reported that head forever; a real pull request's head follows its branch, which is exactly what a revision iteration depends on. Blanking it is how `stored()` in the shipped `<PullRequest>` fixture already spells "whatever that branch holds when this is read". AC0-AC2 and AC5 are unchanged.
1 parent f60b990 commit 5c1edd0

1 file changed

Lines changed: 222 additions & 101 deletions

File tree

0 commit comments

Comments
 (0)