Repository navigation
Commit 4bc489e
committed
🐛 Wait for the reply to be published, not for it to be drawn
The Node shard saw the preview-to-reply journey read a published chat with no
response in it, having just watched the screen say the Sidekick's words. Both
are true at once, and the test was reading the second after waiting for the
first.
Caught locally — once in twenty single-test runs, then again with the state
printed — the file at that moment ends in the control the evaluation had just
taken: owner, ready, conversation, …, control, control-outcome, control. No
response, no feedback. The screen beside it says "[S] Half a thought." and
"[U] think · evaluating the reply" and "[S] working", with Entry 1 already
complete. That is the product doing what it says: the words are shown as soon
as the Sidekick has said them, and the reply carrying an entry is published
once that entry has been evaluated. The two moments are not the same moment.
So the row waits for the fact it goes on to read. `awaitedFact` is `awaited`
for something only an operation can see — the file, here — with the same
deadline and the same loud failure. Nothing is relaxed: one response, one
reply row, no preview row and no "(preview)" on the screen are all still
required, and the screen must still have shown the reply before any of it is
read.
Forty single-test runs after this, none failed. The whole file passes under
Node, Deno and Bun, and no production file moves.1 parent 8aedd19 commit 4bc489e
2 files changed
Lines changed: 32 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1049 | 1049 | | |
1050 | 1050 | | |
1051 | 1051 | | |
| 1052 | + | |
| 1053 | + | |
| 1054 | + | |
| 1055 | + | |
| 1056 | + | |
| 1057 | + | |
| 1058 | + | |
| 1059 | + | |
| 1060 | + | |
| 1061 | + | |
| 1062 | + | |
| 1063 | + | |
| 1064 | + | |
| 1065 | + | |
| 1066 | + | |
| 1067 | + | |
| 1068 | + | |
| 1069 | + | |
| 1070 | + | |
| 1071 | + | |
| 1072 | + | |
| 1073 | + | |
1052 | 1074 | | |
1053 | 1075 | | |
1054 | 1076 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
| 62 | + | |
62 | 63 | | |
63 | 64 | | |
64 | 65 | | |
| |||
1388 | 1389 | | |
1389 | 1390 | | |
1390 | 1391 | | |
| 1392 | + | |
| 1393 | + | |
| 1394 | + | |
| 1395 | + | |
| 1396 | + | |
| 1397 | + | |
| 1398 | + | |
| 1399 | + | |
| 1400 | + | |
1391 | 1401 | | |
1392 | 1402 | | |
1393 | 1403 | | |
| |||
0 commit comments