Repository navigation
Commit 474a03d
committed
📝 State the review components' GitHub mutations accurately (#83)
Five descriptions promised less than their components do, and three of them
hid a mutation of the pull request entirely.
`<SuggestRemoval>` does not simply replace the previous bot review: it deletes
earlier ones only where GitHub permits deletion, so a submitted review can
remain and the old wording's promise that reviews never stack was not one the
component keeps. It now says what it does — delete where allowed, acknowledge
declined suggestions and resolve their threads, then post pending findings as a
new review.
`<CommentReview>` reconciles inline removal suggestions when findings remain and
the GitHub environment is present, and said nothing about it. `<SlopPolicy>` and
`<PrPolicyReport>` compose it, so an author reading either of them was told they
render a section and not that running one writes to the pull request. All three
now disclose it.
`<RepoPolicyReport>` stated the cleanup issues unconditionally, but
`<CleanupIssues>` does nothing without `GITHUB_TOKEN` and `GITHUB_REPOSITORY`.
`Sample.md` and `Instruction.md` each carried a second copy of one metadata key
at the top level, left behind when the prose moved into their `meta:` blocks.
`parseMeta()` treats an explicit `meta:` block as the complete metadata object,
so those copies were read by nobody — `<Sample>` still reports its `as` and
`context` and `<Instruction>` its `context` with them gone. Both pairs stay
byte-equivalent.
The `unused-in-diff` comment still named `.reviews` as the source it reads.
Descriptive metadata and one comment only: no body, schema, form or return
moves, and nothing asserts on this wording.1 parent f31c2ac commit 474a03d
10 files changed
Lines changed: 20 additions & 20 deletions
File tree
- packages
- code-review-agent/src/documents
- components
- policies
- core
- components
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | | - | |
13 | | - | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
26 | | - | |
27 | 25 | | |
28 | 26 | | |
29 | 27 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
17 | 19 | | |
18 | 20 | | |
19 | 21 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
23 | 25 | | |
24 | 26 | | |
25 | 27 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
40 | | - | |
41 | 39 | | |
42 | 40 | | |
43 | 41 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | | - | |
16 | | - | |
17 | | - | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
15 | 17 | | |
16 | 18 | | |
17 | 19 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
26 | | - | |
27 | 25 | | |
28 | 26 | | |
29 | 27 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
40 | | - | |
41 | 39 | | |
42 | 40 | | |
43 | 41 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
37 | | - | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
38 | 39 | | |
39 | 40 | | |
40 | 41 | | |
| |||
0 commit comments