You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 3d0b802
Browse filesBrowse the repository at this point in the historyBrowse files
📝 Finish the value-component sweep and give the reviewer the whole PR
Two inconsistencies left by the return-contract fix.
The migration to value components was described in some places and not
others. The specification still said `Planning` and `Implementation`
return derived `authorized` and `terminal` fields, which they stopped
doing. And the specification, `start.md`, and `primitives.md` all still
described every component body as split by `<Output>` into documentation
under `throw` and a region under `output`. That is true only of the text
components: a value component declares `returns`, renders nothing, cannot
contain `<Output>` at all, and runs its entire body fail-fast, binding
nothing when it fails. Each document now says which kind it is talking
about, and `Planning`, `Implementation`, and `UserCheckpoint` describe
their own bodies as value bodies.
The pull-request reviewer could not see what it was reviewing. #295
resolves reviews, comments, and checks alongside the identities, and the
prompt rendered only number, state, URL, head, and base — while
`runtime.md` denies agent network access, so the planner had no way to
recover the rest. An adversarial review that cannot see a failing check or
an existing objection is uninformed rather than adversarial. Every
category is now rendered explicitly into the review prompt and into the
checkpoint material the user reads, each collection iterated with `<Each>`
rather than stringified, and the prompt names the revision under review:
the diff at `headSha` against `baseSha`, with a verdict describing that
head alone.
The member field names inside reviews, comments, and checks are #295's to
settle; these documents depend on that schema rather than defining a
competing one. What is settled here is that the planner receives the
complete snapshot. The handle stays internal — `start.md` gates on the
verdict and decision — so the earlier claim that nothing consumes it was
wrong, and the PR description is corrected too.
Discrimination adds a structured `<PullRequest>` stub carrying non-empty
reviews, comments, and checks with distinct markers. It captures the
actual rendered planner prompt and the checkpoint material and asserts
every category, both head identities, and the diff instruction reach them.
Omitting any one category reddens exactly its own assertions and leaves
the others green. Nothing in the test uses agent network access. The six
gate scenarios and the three earlier mutations still hold.
0 commit comments