You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 3b9c563
Browse filesBrowse the repository at this point in the historyBrowse files
One way to publish a pair, and one bound that carries its own sentence
Integrates the two actionable comments of the first-green review on PR 997.
Every caller of `publishPair` passed an empty prefix once the upgrade moved to
`copyEntryRecords`, so its body, origin, append branch and the paragraph on why
bytes rather than events are copied described a path nothing took. It is now
`establishPair` followed by `acknowledgePair`, that rationale sits on
`copyEntryRecords`, which is what copies bytes, and the three call sites lose
an argument. One way to create a pair, and the copy is the only thing that
copies.
`copyEntryRecords` passed an infinite bound, which made its `exceeded` sentence
unreachable: the file it reads is one `readRecords` has already opened under the
supported limit. A bound now arrives as the units together with the refusal that
names them, and a reader with no bound passes none and carries no sentence for a
refusal that cannot happen.
The upgrade creates the pair before it reads the older file, so a refused or
cancelled copy leaves an interrupted publication that opening refuses, with the
older file still holding everything. `upgradeExecution` now says so, and names
the one refusal a history this process has already opened can reach: the copy
decodes strictly where `readRecords` decodes leniently. A row covers it — a
legacy history with a byte that begins no UTF-8 sequence opens as one
replacement character, refuses its upgrade by name, keeps every byte, and
reopens as an interrupted publication.
Lenient opening is unchanged: a history that is not UTF-8 still opens, which is
the behavior the review's other option would have changed.
0 commit comments