Repository navigation
Commit 325df34
committed
🧪 Make the Dir evidence discriminate what it claims (#643)
Seven corrections to the previous feedback commit. The production contract, the
public `ensureDirectory` export, the versioned `dir-v2#Dir` identity and the
thirteen accepted descriptions are unchanged.
`Dir.ts` said "It creates nothing", which the change had made false. Its module
documentation now describes what it does: ensure or create the target, then
expand content there, restore the enclosing directory on the way out, and delete
nothing when it does.
FF2's shipped-component half searched the escaping error for content markers.
That could not tell "the content never expanded" from "the content expanded and
its text is not in this message". Sentinel components record whether they ran,
so the assertion is about expansion rather than about a string.
HF26 and ORC6b covered regular files only. Both now cover the frozen matrix: a
regular file and a supported special entry, each at the target and each as an
intermediate. The special entry is a symbolic link to a file — a link to a
directory is a directory to enter, which is the parity decision both providers
make, so using one would have tested the opposite claim.
ORC6 inferred ordering from a nested `<File>` landing, which proves nothing
because a write creates its own parents. A probe now runs first inside the
region and records that the directory already exists and that the contextual
working directory is the ensured target.
ORC6c inferred cwd restoration after cancellation from where a later run's files
landed, but a fresh execution is handed its cwd explicitly. It now reads the
contextual directory from inside the region and again from the enclosing scope
after the halt.
WGAC17 gains the current-admission control as committed evidence: it resumes,
completes, and publishes no further effect or root. Root invariance is described
as what it is — no published mutation — rather than as a call count, which it is
not: an ensure that found the directory already there would publish no root
either. The call count is WF26's, which decorates `mkdir` and counts it.
Four documentation blocks had been orphaned from their declarations by code
inserted between them, WF23's comment still described the ordering proof it no
longer used, and `logicalTarget` was a generator that never yielded.1 parent e195703 commit 325df34
8 files changed
Lines changed: 299 additions & 232 deletions
File tree
- packages
- cli/tests
- runtime
- tests
- workflow
- src
- composition/components
- deno/workspace
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1514 | 1514 | | |
1515 | 1515 | | |
1516 | 1516 | | |
1517 | | - | |
1518 | | - | |
1519 | | - | |
1520 | | - | |
1521 | | - | |
1522 | | - | |
1523 | | - | |
| 1517 | + | |
| 1518 | + | |
| 1519 | + | |
| 1520 | + | |
| 1521 | + | |
| 1522 | + | |
| 1523 | + | |
| 1524 | + | |
| 1525 | + | |
| 1526 | + | |
| 1527 | + | |
1524 | 1528 | | |
1525 | 1529 | | |
1526 | 1530 | | |
| |||
1540 | 1544 | | |
1541 | 1545 | | |
1542 | 1546 | | |
1543 | | - | |
1544 | | - | |
1545 | 1547 | | |
1546 | 1548 | | |
1547 | | - | |
1548 | | - | |
| 1549 | + | |
| 1550 | + | |
1549 | 1551 | | |
1550 | 1552 | | |
1551 | | - | |
1552 | 1553 | | |
1553 | | - | |
| 1554 | + | |
| 1555 | + | |
| 1556 | + | |
| 1557 | + | |
| 1558 | + | |
| 1559 | + | |
| 1560 | + | |
1554 | 1561 | | |
1555 | 1562 | | |
| 1563 | + | |
| 1564 | + | |
1556 | 1565 | | |
1557 | | - | |
| 1566 | + | |
| 1567 | + | |
| 1568 | + | |
| 1569 | + | |
| 1570 | + | |
| 1571 | + | |
| 1572 | + | |
| 1573 | + | |
| 1574 | + | |
| 1575 | + | |
| 1576 | + | |
| 1577 | + | |
| 1578 | + | |
| 1579 | + | |
| 1580 | + | |
| 1581 | + | |
| 1582 | + | |
| 1583 | + | |
| 1584 | + | |
| 1585 | + | |
| 1586 | + | |
| 1587 | + | |
| 1588 | + | |
| 1589 | + | |
| 1590 | + | |
| 1591 | + | |
| 1592 | + | |
| 1593 | + | |
| 1594 | + | |
| 1595 | + | |
| 1596 | + | |
| 1597 | + | |
| 1598 | + | |
| 1599 | + | |
| 1600 | + | |
| 1601 | + | |
| 1602 | + | |
| 1603 | + | |
| 1604 | + | |
1558 | 1605 | | |
1559 | 1606 | | |
1560 | 1607 | | |
| |||
1572 | 1619 | | |
1573 | 1620 | | |
1574 | 1621 | | |
1575 | | - | |
| 1622 | + | |
| 1623 | + | |
1576 | 1624 | | |
1577 | 1625 | | |
1578 | 1626 | | |
1579 | 1627 | | |
1580 | 1628 | | |
1581 | 1629 | | |
1582 | | - | |
1583 | | - | |
1584 | | - | |
1585 | | - | |
1586 | | - | |
1587 | | - | |
1588 | | - | |
1589 | | - | |
1590 | | - | |
1591 | | - | |
1592 | | - | |
1593 | | - | |
1594 | | - | |
1595 | | - | |
1596 | | - | |
1597 | | - | |
1598 | | - | |
1599 | | - | |
1600 | | - | |
1601 | | - | |
1602 | | - | |
1603 | | - | |
1604 | | - | |
1605 | | - | |
1606 | | - | |
1607 | | - | |
1608 | | - | |
1609 | | - | |
1610 | | - | |
1611 | | - | |
1612 | | - | |
1613 | | - | |
1614 | | - | |
1615 | | - | |
1616 | | - | |
1617 | | - | |
1618 | | - | |
1619 | | - | |
1620 | | - | |
1621 | | - | |
1622 | | - | |
1623 | | - | |
1624 | | - | |
1625 | | - | |
1626 | | - | |
1627 | | - | |
1628 | | - | |
1629 | | - | |
1630 | | - | |
1631 | | - | |
1632 | | - | |
1633 | | - | |
1634 | | - | |
1635 | | - | |
1636 | | - | |
1637 | | - | |
1638 | | - | |
1639 | | - | |
1640 | | - | |
1641 | | - | |
1642 | | - | |
1643 | | - | |
1644 | | - | |
1645 | | - | |
1646 | | - | |
1647 | | - | |
1648 | | - | |
1649 | | - | |
1650 | | - | |
1651 | | - | |
1652 | | - | |
1653 | | - | |
1654 | | - | |
1655 | | - | |
1656 | | - | |
1657 | | - | |
1658 | | - | |
1659 | | - | |
1660 | | - | |
1661 | | - | |
1662 | | - | |
1663 | | - | |
1664 | | - | |
1665 | | - | |
1666 | | - | |
1667 | | - | |
1668 | | - | |
1669 | | - | |
1670 | | - | |
1671 | | - | |
1672 | | - | |
1673 | | - | |
1674 | | - | |
1675 | | - | |
1676 | | - | |
1677 | | - | |
1678 | | - | |
1679 | | - | |
1680 | | - | |
1681 | | - | |
1682 | | - | |
1683 | | - | |
1684 | | - | |
1685 | | - | |
1686 | | - | |
1687 | | - | |
1688 | | - | |
1689 | | - | |
1690 | | - | |
1691 | | - | |
1692 | | - | |
1693 | | - | |
1694 | | - | |
1695 | | - | |
1696 | | - | |
1697 | | - | |
1698 | | - | |
1699 | | - | |
1700 | | - | |
| 1630 | + | |
1701 | 1631 | | |
1702 | 1632 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
582 | 582 | | |
583 | 583 | | |
584 | 584 | | |
585 | | - | |
586 | | - | |
587 | | - | |
588 | | - | |
589 | | - | |
590 | | - | |
591 | | - | |
592 | | - | |
593 | | - | |
594 | 585 | | |
595 | 586 | | |
596 | 587 | | |
| |||
644 | 635 | | |
645 | 636 | | |
646 | 637 | | |
| 638 | + | |
| 639 | + | |
| 640 | + | |
| 641 | + | |
| 642 | + | |
| 643 | + | |
| 644 | + | |
| 645 | + | |
| 646 | + | |
647 | 647 | | |
648 | 648 | | |
649 | 649 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1231 | 1231 | | |
1232 | 1232 | | |
1233 | 1233 | | |
1234 | | - | |
| 1234 | + | |
| 1235 | + | |
| 1236 | + | |
| 1237 | + | |
| 1238 | + | |
| 1239 | + | |
| 1240 | + | |
| 1241 | + | |
| 1242 | + | |
| 1243 | + | |
| 1244 | + | |
| 1245 | + | |
1235 | 1246 | | |
1236 | 1247 | | |
1237 | 1248 | | |
| 1249 | + | |
| 1250 | + | |
| 1251 | + | |
| 1252 | + | |
| 1253 | + | |
| 1254 | + | |
| 1255 | + | |
| 1256 | + | |
| 1257 | + | |
| 1258 | + | |
| 1259 | + | |
| 1260 | + | |
| 1261 | + | |
| 1262 | + | |
| 1263 | + | |
| 1264 | + | |
| 1265 | + | |
| 1266 | + | |
| 1267 | + | |
| 1268 | + | |
| 1269 | + | |
| 1270 | + | |
| 1271 | + | |
| 1272 | + | |
| 1273 | + | |
| 1274 | + | |
| 1275 | + | |
| 1276 | + | |
| 1277 | + | |
| 1278 | + | |
| 1279 | + | |
| 1280 | + | |
1238 | 1281 | | |
1239 | | - | |
1240 | | - | |
1241 | | - | |
1242 | | - | |
1243 | | - | |
1244 | | - | |
1245 | | - | |
1246 | | - | |
| 1282 | + | |
| 1283 | + | |
1247 | 1284 | | |
1248 | 1285 | | |
1249 | 1286 | | |
1250 | | - | |
1251 | | - | |
1252 | | - | |
1253 | | - | |
1254 | | - | |
1255 | | - | |
1256 | | - | |
1257 | | - | |
1258 | | - | |
1259 | | - | |
1260 | | - | |
1261 | | - | |
1262 | | - | |
1263 | | - | |
1264 | | - | |
| 1287 | + | |
| 1288 | + | |
1265 | 1289 | | |
1266 | 1290 | | |
1267 | 1291 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
9 | 12 | | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
15 | 25 | | |
16 | 26 | | |
17 | 27 | | |
| |||
0 commit comments