Repository navigation
Commit 2cdbb97
committed
🔎 Ask one surface for a pull request, and name it by URL
Replaces the request-only route and invocation-private terminal with the
topology `<Issue>` already has: one `PullRequestApi` carrying `read(url,
options)` and `upsert(pullRequest, options)`, reached under
`executablemd.workflow.pull-request`, where a provider is ordinary middleware.
It recognizes the URLs it can act on, delegates the rest untouched, and once it
matches, its answer and its refusal are final.
Reads name a pull request by canonical URL. No `<Repository>`, no working
directory, no attachment: the URL is the identity and the selected provider
parses the repository and number out of it. Canonicalization is provider-neutral
and happens first, so the component, the durable request and every adapter read
one answer. Implicit selection is public `github.com`; an explicit
`provider="github"` reaches the same path shape on a self-hosted host.
`upsertPullRequest` moves off `GitComposition` onto the same surface and keeps
returning the complete `PullRequestResult`. Issue answers with a URL alone
because that is the whole of its portable contract; a pull request already has a
stronger shipped one, and #301's create/update loop reads `number` back on its
next pass.
Which pull requests may be read is now operator configuration:
`XMD_WORKFLOW_GITHUB_PULL_REQUESTS` with `allowed` and an optional `endpoint`,
read once when the Deno host is constructed and refused rather than narrowed
when it is malformed. `allowed` rather than `ceiling` — the shipped issues
contract keeps its word, and an operator writes the list of places this host may
reach. Absence authorizes no URL read and disables nothing else: the adapter is
installed on every live or partial attachment, its read method delegates to the
surface's base error, and `<PullRequest>` upserts on this run's own Push
evidence, which no configuration grants or withdraws.
Two things the fork evidence found. A `pull_request_read` was classified
`unsupported-effect`, so no checkpoint at or after one could be forked; it joins
`fetch` in the inheritable set for the same reason — it changed nothing at the
host, and the record holds the collection itself. And the run was in the effect
*name*, which made every inherited read a different effect: it stays in the
retained request, where it says who asked, and leaves the name to the question.
PRR27 forks at the completed read itself. The control fork with the inherited
URL restores the collection and sends no second request; a fork overriding
`--props-url` diverges at that position and neither restores nor binds the
earlier evidence. The unchanged control is asserted first on purpose — without
it the changed branch would diverge for reasons that have nothing to do with the
URL.
PRR19, PRR20/20b, PRR21, PRR25 and PRR28 replace the superseded terminal
attacks; PRR23 now proves URL, discriminator and collection all name the effect.
Architecture, both specifications and the PR description follow.
Refs #5761 parent 2c26588 commit 2cdbb97
25 files changed
Lines changed: 1706 additions & 1084 deletions
File tree
- packages
- cli
- src
- tests
- support
- workflow
- src
- composition
- components
- deno
- composition
- workspace
- lifecycle
- tests
- scripts
- specs
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
71 | | - | |
| 71 | + | |
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
| |||
1285 | 1285 | | |
1286 | 1286 | | |
1287 | 1287 | | |
1288 | | - | |
1289 | | - | |
1290 | | - | |
1291 | | - | |
1292 | | - | |
1293 | | - | |
1294 | | - | |
1295 | | - | |
1296 | | - | |
1297 | | - | |
1298 | | - | |
1299 | | - | |
| 1288 | + | |
| 1289 | + | |
| 1290 | + | |
| 1291 | + | |
| 1292 | + | |
| 1293 | + | |
| 1294 | + | |
| 1295 | + | |
| 1296 | + | |
| 1297 | + | |
| 1298 | + | |
| 1299 | + | |
| 1300 | + | |
| 1301 | + | |
1300 | 1302 | | |
1301 | 1303 | | |
1302 | 1304 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| 37 | + | |
37 | 38 | | |
38 | 39 | | |
39 | 40 | | |
| |||
50 | 51 | | |
51 | 52 | | |
52 | 53 | | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
53 | 57 | | |
54 | 58 | | |
55 | 59 | | |
| |||
63 | 67 | | |
64 | 68 | | |
65 | 69 | | |
| 70 | + | |
66 | 71 | | |
67 | 72 | | |
68 | 73 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
0 commit comments