Skip to content

Commit 21ff698

Browse files
committed
📝 Say the composition is what remains, and stop contradicting it
Six exact claims outlived the capabilities that disproved them, and one of them was damage I introduced while fixing another. `<Fetch>` no longer owns the pull-request evidence: the specification said "that read is `<Fetch>`'s" and "no stage writes those fetches yet" three sections away from the stage that now writes all three URL-addressed reads. Default-on secret rejection was still listed open in the primitives matrix after #573 and #575 shipped it. And one sentence read "That gate is and that gate is default-on" — a duplicated fragment from an earlier edit, which is exactly the kind of repair that should be made in place rather than appended later. The larger correction is what #301 slice 2 *is*. Four passages called it "scheduling the loop and continuing it unattended", which is the opposite of the boundary: slice 2 is the composition — the authored loop from discovery through acceptance under one run — and scheduling, watchers and unattended resume are deliberately outside it, with the later scheduling slice belonging to #300. Two more presented running the stages by hand under `xmd run` as the current execution path; it is history, and the composed root runs under `xmd workflow start`. The sweeps missed every one of these while exiting 0, which is the real defect. They now carry the nine exact defective sentences from the previous head as forbidden forms, self-tested, and fail against that revision while passing here. A scan for repeated phrases guards the duplication class directly, since a sweep that only knows the claims it was taught cannot see prose damage. The planning record is collapsed to match: the A/B/C sequence is gone from the composition plan, the implementor handoff and issue #301. A shipped in #577, B shipped in #580, and PR #181 owns C. The twelve-criterion matrix is unchanged — only its ownership column moves, with criteria 2 and 2a inherited from #577 and criterion 6's provider and replay halves from #580.
1 parent a76a507 commit 21ff698

3 files changed

Lines changed: 50 additions & 31 deletions

File tree

‎specs/adversarial-implementation-workflow.md‎

Lines changed: 35 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -169,14 +169,19 @@ the component from its retained source, a mutable checkout beside the definition
169169
substitutes nothing, and an undeclared name resolves to nothing at all. Ordinary
170170
`xmd run` resolution is unchanged.
171171

172-
What #301 still owes is the supervised composition: scheduling the loop and
173-
continuing it unattended. Reaching the stage names is not running the workflow.
174-
175-
The stages that run today therefore run under `xmd run`, in one document
176-
execution and one existing working directory, with the user inspecting each
177-
result and starting the next stage. That manual boundary lets the exercise test
178-
the interview, handoff, plan, review, decision, and revision contracts while the
179-
retained environment around them is completed.
172+
What #301 slice 2 owes is the composition itself: the authored loop that runs
173+
discovery, planning, authorization, evaluation, Git, the pull request, its
174+
evidence reads, review, deferred issues and acceptance as one workflow run. That
175+
is what this document now writes. Scheduling, watchers and unattended
176+
continuation are deliberately outside it — a resume stays an explicit act, and
177+
the later scheduling slice is #300's.
178+
179+
The composed root runs under `xmd workflow start`, which is the current
180+
execution path for it: one retained Workspace, the stage names resolved from the
181+
pinned definition commit, and a checkpoint that suspends the run durably rather
182+
than blocking it. Running the stages by hand under `xmd run`, one at a time with
183+
a person starting the next, is how the exercise was tested before the retained
184+
environment existed; it is history rather than the way this root is run.
180185

181186
The automated form treats execution as a loop. An iteration stops on the first
182187
applicable signal in this priority order:
@@ -294,14 +299,18 @@ stable provider identity, number, URL, open state, head SHA and base SHA (#295,
294299
shipped). Existing reviews,
295300
comments and check results are separate reads rather than fields on a creation
296301
result that would otherwise claim to stay fresh against a remote that keeps
297-
changing. **That read is `<Fetch>`'s** (#456, shipped): a document reads over
298-
HTTP and retains what it read, so a network-denied reviewer can be handed a pull
299-
request's current state without the Agent ever reaching the network. The
300-
requirement it must satisfy is unchanged: the reviewer receives every existing
301-
review with its body, every comment, and every check result, iterated rather
302-
than stringified — a review that cannot see a failing check or an existing
303-
objection is not adversarial, it is uninformed. No stage writes those fetches
304-
yet, and admitting `<Fetch>` inside generated XMD remains #369's.
302+
changing. **Those reads are their own components** (#576, delivered by #580):
303+
`<PullRequest.Reviews>`, `<PullRequest.Comments>` and `<PullRequest.Checks>`,
304+
each addressed by the pull request's own `url` and binding its normalized
305+
retained collection. They are three independent durable effects, so a replay
306+
hands back what the run recorded and performs no second read, and a
307+
network-denied reviewer is handed the pull request's state without the Agent
308+
ever reaching the network. The requirement they satisfy is unchanged: the
309+
reviewer receives every existing review with its body, every comment, and every
310+
check result, iterated rather than stringified — a review that cannot see a
311+
failing check or an existing objection is not adversarial, it is uninformed.
312+
The implementation stage writes all three. They are not `<Fetch>`, they author
313+
no repository or number, and a generated fragment reaches none of them.
305314

306315
The user's checkpoint carries the same evidence. An existing objection reaches
307316
the person approving the change in its own words, not only as the planner
@@ -569,7 +578,7 @@ touched and why deleting a run never claims to undo a push.
569578
Co-location does not make arbitrary filesystem content journal or training data.
570579
Journal events reach storage already filtered by the pre-persistence secret
571580
gate, and storage adds no second policy: a rejected gate leaves nothing behind.
572-
That gate is and that gate is **default-on** (#199, delivered by #573 and #575).
581+
That gate is **default-on** (#199, delivered by #573 and #575).
573582
Offline detection is installed before the first live event. An offending durable
574583
event is refused before persistence; a rendered chunk the scanner cannot clear is
575584
withheld whole, while an earlier cleared prefix stays observable. Withholding
@@ -907,13 +916,15 @@ The user triggers each stage manually. Required content is rendered directly int
907916
later prompts from restored values, and generated artifacts do not appear in a
908917
checkout unless the user explicitly exports them.
909918

910-
The exercise runs under `xmd run`, in one document execution and one existing
911-
working directory. The document logic — instruction discovery, the planner
912-
interview, plan convergence, the bounded repair turns, and the user gate — is
913-
executable on shipped syntax today, and a workflow run can now give it both a
914-
checkout (#293) and its stage names, which the root declares as a component
915-
bundle resolved from the pinned commit (#493). What it cannot yet give is the
916-
supervision: scheduling the loop and continuing it unattended remain #301's.
919+
The composed root runs under `xmd workflow start`. The document logic —
920+
instruction discovery, the planner interview, plan convergence, the bounded
921+
repair turns, and the user gate — is executable on shipped syntax, and a workflow
922+
run gives it a retained Workspace, a checkout (#293) and its stage names, which
923+
the root declares as a component
924+
bundle resolved from the pinned commit (#493), and a checkpoint that suspends
925+
the run durably rather than blocking it (#577). What stays outside the
926+
composition is anything automatic: scheduling a resume and continuing a run
927+
unattended are excluded here, and the later scheduling slice is #300's.
917928

918929
The exercise succeeds when:
919930

‎workflows/adversarial-implementation/primitives.md‎

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -354,8 +354,12 @@ the component from its retained source rather than from a mutable checkout. A
354354
same-named file beside the definition answers nothing, an undeclared name
355355
resolves to nothing at all, and ordinary `xmd run` resolution is unchanged.
356356

357-
What #301 still owes is the supervised composition itself: scheduling the loop
358-
and continuing it unattended. Reachable stage names are not a running workflow.
357+
What #301 slice 2 owes is the composition itself: the authored loop that runs
358+
discovery, planning, authorization, evaluation, Git, the pull request, its
359+
evidence reads, review, deferred issues and acceptance as one workflow run. That
360+
is what this document now writes. Scheduling, watchers and unattended
361+
continuation are deliberately outside it — a resume stays an explicit act, and
362+
the later scheduling slice is #300's.
359363

360364
**2. Repository and deterministic Git composition.**
361365

@@ -480,10 +484,11 @@ whole. This workflow performs those itself, as authored effects after
480484
| synchronize this living target with settled contracts | #292 | this change |
481485
| prove the shipped planning-document logic | #290 | this change — the proof lands here; #290 closes on delivery |
482486
| a root's declared component bundle, resolved from its pinned commit | #301 slice, delivered by #493 | shipped |
483-
| compose the supervised workflow — scheduling the loop, continuing it unattended | #301 | open |
487+
| compose the supervised workflow — the authored loop from discovery to acceptance under one run | #301 slice 2 | this change |
488+
| schedule a resume, or continue a run unattended | #300 slice 2 | open — deliberately outside #301 slice 2 |
484489
| omit an expression prop that evaluates to `undefined`, before validation and before the durable JSON boundary | #301 | open — architecture settled; `Implementation`'s one-invocation pull-request loop depends on it |
485490
| typed durable answer delivery to a suspended run | #300 | shipped — delivery is non-executing; automatic scheduling is not shipped |
486-
| default-on secret rejection before journal persistence | #199 | open — guard and scanner built |
491+
| default-on secret rejection before journal persistence | #199, delivered by #573 and #575 | shipped |
487492
| certify interruption, replay, authority, reconciliation, and cross-runtime behavior | #299 | open |
488493

489494
`<Discovery>`, `<Planning>`, `<Implementation>`, and `<UserCheckpoint>` are

‎workflows/adversarial-implementation/start.md‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -544,9 +544,12 @@ resolution is unchanged — there the five resolve as ordinary repository
544544
components on its search path, and `<Repository>`, `<Worktree>` and `<Dir>` do
545545
*not* resolve, because plain `xmd run` composes no workflow.
546546

547-
What #301 still owes is the supervised composition itself — scheduling the loop
548-
and continuing it unattended. The bundle makes the stage names reachable; it
549-
does not make the workflow run.
547+
What #301 slice 2 owes is the composition itself: the authored loop that runs
548+
discovery, planning, authorization, evaluation, Git, the pull request, its
549+
evidence reads, review, deferred issues and acceptance as one workflow run. That
550+
is what this document now writes. Scheduling, watchers and unattended
551+
continuation are deliberately outside it — a resume stays an explicit act, and
552+
the later scheduling slice is #300's.
550553

551554
## Rendered data flow
552555

0 commit comments

Comments
 (0)