Repository navigation
Commit 13fafa6
committed
🐛 Write the syntax catalog whole, and state the CLI tier's commit identity (#643)
Two failures, both revealed rather than caused by the previous commit: the
stale publish workflow had been killing all nine `test-deno` shards before a
test ran, so nothing underneath it had been reported yet.
## The catalog was truncated when stdout was a pipe
`process.stdout` is synchronous for a file or a terminal and asynchronous for a
pipe, and the `syntax` case handed its whole document to `write` without
waiting. The run then ended and the process exited with most of the document
still in a buffer, so `xmd syntax --json > file` was whole at 89252 bytes while
`xmd syntax --json | …` stopped at 65394 — inside a token, which is why the
reader saw "Unexpected end of JSON input" rather than a short catalog.
This became visible now because this branch registers the repository
vocabulary in the catalog, which is what first pushed it past the buffer. The
write now waits for the callback, so it finishes before anything can exit.
Only that one write is changed. The other large writes in this file stream in
chunks rather than handing over a single document, and none of them is near the
buffer.
## The CLI tier read the host's Git identity
`runOrdinary` installed the provider without saying who a commit is by, so it
fell through to the production default — the caller's own `git config`. ORC18
and ORC15 therefore asserted something about who ran them: green on a machine
with `user.name` set, `UnresolvedGitIdentityError` on every runner. It now
states a fixture identity, the same correction the workflow tier already
carries. ORC19 was never affected: it commits inside a subprocess whose
environment it builds itself.
Verified against a reproduced runner rather than a reading — with
`user.useConfigOnly` set and no configuration file, the four CLI suites pass
11/33, and the npm-bin suite passes 1/2 with a rebuilt package.1 parent f2ca658 commit 13fafa6
2 files changed
Lines changed: 38 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2429 | 2429 | | |
2430 | 2430 | | |
2431 | 2431 | | |
2432 | | - | |
| 2432 | + | |
2433 | 2433 | | |
2434 | 2434 | | |
2435 | 2435 | | |
| |||
2530 | 2530 | | |
2531 | 2531 | | |
2532 | 2532 | | |
| 2533 | + | |
| 2534 | + | |
| 2535 | + | |
| 2536 | + | |
| 2537 | + | |
| 2538 | + | |
| 2539 | + | |
| 2540 | + | |
| 2541 | + | |
| 2542 | + | |
| 2543 | + | |
| 2544 | + | |
| 2545 | + | |
| 2546 | + | |
| 2547 | + | |
| 2548 | + | |
| 2549 | + | |
| 2550 | + | |
| 2551 | + | |
| 2552 | + | |
| 2553 | + | |
2533 | 2554 | | |
2534 | 2555 | | |
2535 | 2556 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
96 | | - | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
97 | 104 | | |
98 | 105 | | |
99 | 106 | | |
| |||
117 | 124 | | |
118 | 125 | | |
119 | 126 | | |
120 | | - | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
121 | 135 | | |
122 | 136 | | |
123 | 137 | | |
| |||
0 commit comments