Repository navigation
Commit 0b73cbb
authored
🤖 Bound implementation feedback and review closure (#437)
* 📝 Give architecture review a condition for being finished
The sequence around #432 and #433 found real defects while the threat
model, the blocker criteria and the acceptance boundary were still
moving. Each round was reasonable; together they had no stated point at
which review was complete, so adjacent invariants kept arriving.
AGENTS.md now names which changes are architecture-sensitive, when a
finding blocks the PR in front of it, the three classes a finding falls
into, and how a review closes: one consolidated ruling after two
correction rounds, reported against at one exact head.
The role contracts carry the depth. The Architect owns the settled
record and its template, and issues the consolidated ruling. The Planner
carries the frozen checklist into the handoff and routes new
architecture decisions back instead of embedding them in an
implementation prompt. The Implementor maps corrections to that
checklist and names a requested scope expansion rather than absorbing
it.
Ordinary PRs are unchanged: the template's new section is deleted like
every other section that does not apply.
* 🤖 Bound implementation feedback and review closure
Feedback used to wait on the delivery battery: lint, typecheck and the JSR
dry run were prerequisites for any commit touching source or tests, so a
reviewer waited on checks that could not discriminate the change. Review had
no finite boundary either, and an architecture round could introduce an
adjacent invariant indefinitely.
Verification now names two boundaries. A feedback commit is the stable
revision offered once the smallest affected evidence passes, handed over as an
exact SHA with every focused command. Delivery keeps the exhaustive battery and
required CI, and branch protection stays authoritative for merge.
Both reviewing roles read one exact commit and never inspect, monitor or wait
for CI; a passing verdict is unqualified. The Architect blocks only on a
structural consequence from a closed list, reproduced or directly traced at
that commit, and names the SHA, invariant, reproducer, surface, consequence and
PR-purpose rationale. The Planner owns evidence sufficiency and freezes the
acceptance matrix the Implementor executes. A non-blocking observation is
tracked only when the Planner judges it worth tracking.
The dependency, release, generated-artifact, cache-purity, flake and main-health
procedures are unchanged.
---------
Co-authored-by: Taras Mankovski <[email protected]>1 parent 1387222 commit 0b73cbb
5 files changed
Lines changed: 330 additions & 49 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
27 | | - | |
| 26 | + | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
32 | | - | |
| 31 | + | |
| 32 | + | |
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
37 | | - | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
38 | 42 | | |
39 | 43 | | |
40 | 44 | | |
| |||
53 | 57 | | |
54 | 58 | | |
55 | 59 | | |
56 | | - | |
| 60 | + | |
57 | 61 | | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
67 | 134 | | |
68 | 135 | | |
69 | 136 | | |
70 | 137 | | |
71 | 138 | | |
72 | | - | |
73 | | - | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
74 | 142 | | |
75 | 143 | | |
76 | 144 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
| |||
48 | 49 | | |
49 | 50 | | |
50 | 51 | | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
51 | 83 | | |
52 | 84 | | |
53 | 85 | | |
| |||
65 | 97 | | |
66 | 98 | | |
67 | 99 | | |
68 | | - | |
69 | | - | |
70 | | - | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
71 | 103 | | |
72 | 104 | | |
73 | 105 | | |
74 | 106 | | |
75 | 107 | | |
76 | 108 | | |
77 | | - | |
78 | | - | |
79 | | - | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
| 20 | + | |
19 | 21 | | |
20 | 22 | | |
21 | 23 | | |
| |||
68 | 70 | | |
69 | 71 | | |
70 | 72 | | |
| 73 | + | |
71 | 74 | | |
72 | | - | |
| 75 | + | |
| 76 | + | |
73 | 77 | | |
74 | 78 | | |
75 | 79 | | |
76 | 80 | | |
77 | | - | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
78 | 113 | | |
79 | 114 | | |
80 | 115 | | |
| |||
86 | 121 | | |
87 | 122 | | |
88 | 123 | | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
89 | 137 | | |
90 | 138 | | |
91 | 139 | | |
92 | | - | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
0 commit comments