Repository navigation
Commit 0217795
committed
🚨 Recognize an authored stop, and let every other failure escape (#939)
Repairs the three PR-caused CI failures at 1043460. The base and the
pre-correction PR head were both green, so all of them were this
correction's.
10f3cc8 made every undescribed error the document's own outcome, which
is the opposite of what the settling boundary has always decided:
`documentationFailure` reports a document's failure as its own outcome and
lets anything else escape as infrastructure. Git protocol refusals,
retained-history rejections, assertion aborts and a missing launcher were
being reported as document results instead of escaping.
The guard is restored with one narrow exception. A valid `<Fail>` marks the
Error it raises with a stable namespaced non-enumerable own property, and
the boundary reads that mark off the object it was handed. So the one
undescribed failure that is a decision the document made keeps its ordinary
result, its rendered text and its computed data, and every other undescribed
failure is rethrown unchanged. Nothing identifies it by class, name or
message: `<Fail>` still raises an ordinary Error carrying exactly the
author's sentence, through ordinary component reporting and recovery, and an
invocation `<Fail>` refuses is never marked. The mark is non-enumerable and
is never searched for underneath a wrapper, so a failure that merely carries
an authored stop as its cause is not adopted as one.
Separately, babfb6f pushed a binding checkpoint at the root Close's own
marker, and the REPL keys checkpoints by marker — so one marker had two
children with one key and the drawer refused to reconcile. The Close's
terminal checkpoint already owns that selectable position and the computed
data arrives with that outcome, so the second checkpoint is gone. The
binding transcript row, the terminal's bindings and the merged entry data
are unchanged.
And the new JSDoc line that failed the banned-words check is reworded.1 parent 1043460 commit 0217795
3 files changed
Lines changed: 78 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
790 | 790 | | |
791 | 791 | | |
792 | 792 | | |
793 | | - | |
794 | 793 | | |
795 | 794 | | |
796 | 795 | | |
| |||
1655 | 1654 | | |
1656 | 1655 | | |
1657 | 1656 | | |
1658 | | - | |
| 1657 | + | |
| 1658 | + | |
| 1659 | + | |
1659 | 1660 | | |
1660 | 1661 | | |
1661 | 1662 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
43 | 97 | | |
44 | 98 | | |
45 | 99 | | |
| |||
48 | 102 | | |
49 | 103 | | |
50 | 104 | | |
51 | | - | |
| 105 | + | |
52 | 106 | | |
53 | 107 | | |
54 | 108 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
201 | 201 | | |
202 | 202 | | |
203 | 203 | | |
| 204 | + | |
204 | 205 | | |
205 | 206 | | |
206 | 207 | | |
| |||
2003 | 2004 | | |
2004 | 2005 | | |
2005 | 2006 | | |
2006 | | - | |
| 2007 | + | |
2007 | 2008 | | |
2008 | 2009 | | |
2009 | 2010 | | |
| |||
2424 | 2425 | | |
2425 | 2426 | | |
2426 | 2427 | | |
2427 | | - | |
2428 | | - | |
2429 | | - | |
2430 | | - | |
2431 | | - | |
2432 | | - | |
2433 | | - | |
| 2428 | + | |
| 2429 | + | |
| 2430 | + | |
| 2431 | + | |
| 2432 | + | |
| 2433 | + | |
| 2434 | + | |
| 2435 | + | |
| 2436 | + | |
| 2437 | + | |
| 2438 | + | |
| 2439 | + | |
| 2440 | + | |
| 2441 | + | |
| 2442 | + | |
2434 | 2443 | | |
| 2444 | + | |
| 2445 | + | |
| 2446 | + | |
2435 | 2447 | | |
2436 | 2448 | | |
2437 | 2449 | | |
| |||
0 commit comments