ci: fix http dependency in tests#316
Merged
yngvar-antonsson merged 1 commit intomasterfrom Oct 29, 2021
Merged
Conversation
|
The http v2 still available, but is not recommended. I suggest to use v1. |
ylobankov
force-pushed
the
ylobankov/fix-http-dependency-in-tests
branch
2 times, most recently
from
dcb3db3 to
6bc863d
Compare
At this moment http dependency in tests is broken since we are trying to install the `http 2.1.0` lua rock. Now this rock is not available anymore due to tarantool/http#142 and that is the reason for test failures with the following error: http not found for Lua 5.1. Error: No results matching query were found for Lua 5.1. Checking if available for other Lua versions... make: *** [Makefile:10: .rocks] Error 1 Checking for Lua 5.2... Checking for Lua 5.3... Checking for Lua 5.4... Error: Process completed with exit code 2. Now http v2 is available under the `http-v2-legacy` lua rock and this patch switches the use of `http 2.1.0` to `http-v2-legacy 2.1.0`.
ylobankov
force-pushed
the
ylobankov/fix-http-dependency-in-tests
branch
from
6bc863d to
2d2d86b
Compare
yngvar-antonsson
approved these changes
Oct 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At this moment http dependency in tests is broken since we are trying
to install the
http 2.1.0lua rock. Now this rock is not availableanymore due to tarantool/http#142 and that is the reason for test
failures with the following error:
Now http v2 is available under the
http-v2-legacylua rock and thispatch switches the use of
http 2.1.0tohttp-v2-legacy 2.1.0.Manual test run with
http-v2-legacy 2.1.0.