Skip to content

[BUG] Newer versions don't acknowledge istanbul ignore comments #1027

@reggi

Description

@reggi

Is there an existing issue for this?

  • I have searched the existing issues

Have you read the CONTRIBUTING guide on posting bugs, and CODE_OF_CONDUCT?

  • yes I read the things

This issue exists in the latest tap version

  • I am using the latest tap

Description

I have a /* istanbul ignore next */ comment on a function and it's showing that the lines in this file that should be ignored are uncovered.

Reproduction

https://github.com/reggi/demo-tap-istanbul-ignore-issue

Environment

➜  demo-tap-istanbul-ignore-issue git:(main) which tap
npm ls tap
tap versions
tap config list
tap plugin list
# if using typescript:
npm ls @isaacs/ts-node-temp-fork-for-pr-2009
npm ls typescript
tap not found
npm verb cli /Users/reggi/.nvm/versions/node/v20.12.2/bin/node /Users/reggi/.nvm/versions/node/v20.12.2/bin/npm
npm info using [email protected]
npm info using [email protected]
npm verb title npm ls tap
npm verb argv "ls" "tap"
npm verb logfile logs-max:10 dir:/Users/reggi/.npm/_logs/2024-05-30T17_24_33_387Z-
npm verb logfile /Users/reggi/.npm/_logs/2024-05-30T17_24_33_387Z-debug-0.log
npm sill logfile start cleaning logs, removing 1 files
npm sill logfile done cleaning log files
[email protected] /Users/reggi/Desktop/demo-tap-istanbul-ignore-issue
└── [email protected]

npm verb exit 0
npm info ok 
zsh: command not found: tap
zsh: command not found: tap
zsh: command not found: tap
npm verb cli /Users/reggi/.nvm/versions/node/v20.12.2/bin/node /Users/reggi/.nvm/versions/node/v20.12.2/bin/npm
npm info using [email protected]
npm info using [email protected]
npm verb title npm ls @isaacs/ts-node-temp-fork-for-pr-2009
npm verb argv "ls" "@isaacs/ts-node-temp-fork-for-pr-2009"
npm verb logfile logs-max:10 dir:/Users/reggi/.npm/_logs/2024-05-30T17_24_33_850Z-
npm verb logfile /Users/reggi/.npm/_logs/2024-05-30T17_24_33_850Z-debug-0.log
npm sill logfile start cleaning logs, removing 1 files
npm sill logfile done cleaning log files
[email protected] /Users/reggi/Desktop/demo-tap-istanbul-ignore-issue
└─┬ [email protected]
  ├─┬ @tapjs/[email protected]
  │ └── @isaacs/[email protected]
  └─┬ @tapjs/[email protected]
    └── @isaacs/[email protected] deduped

npm verb exit 0
npm info ok 
npm verb cli /Users/reggi/.nvm/versions/node/v20.12.2/bin/node /Users/reggi/.nvm/versions/node/v20.12.2/bin/npm
npm info using [email protected]
npm info using [email protected]
npm verb title npm ls typescript
npm verb argv "ls" "typescript"
npm verb logfile logs-max:10 dir:/Users/reggi/.npm/_logs/2024-05-30T17_24_34_287Z-
npm verb logfile /Users/reggi/.npm/_logs/2024-05-30T17_24_34_287Z-debug-0.log
npm sill logfile start cleaning logs, removing 1 files
npm sill logfile done cleaning log files
[email protected] /Users/reggi/Desktop/demo-tap-istanbul-ignore-issue
└─┬ [email protected]
  └─┬ @tapjs/[email protected]
    ├─┬ @isaacs/[email protected]
    │ └── [email protected] deduped
    ├─┬ [email protected]
    │ └── [email protected] deduped
    └── [email protected]

npm verb exit 0
npm info ok 

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugsomething not go good

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions