Handle EPIPE better in exceptional edge cases

isaacs · isaacs · commit 283c8e64f781 · 2018-02-19T15:19:36.000-08:00
Fix #422
diff --git a/lib/tap.js b/lib/tap.js
@@ -9,9 +9,9 @@ const _didPipe = Symbol('_didPipe')
 
 const monkeypatchEpipe = () => {
   const emit = process.stdout.emit
-  process.stdout.emit = (ev, er) => {
+  process.stdout.emit = function (ev, er) {
     if (ev !== 'error' || er.code !== 'EPIPE')
-      return emit.apply(process, arguments)
+      return emit.apply(process.stdout, arguments)
   }
 }
 
diff --git a/test/regression-many-asserts-epipe.js b/test/regression-many-asserts-epipe.js
@@ -0,0 +1,9 @@
+'use strict'
+// See https://github.com/tapjs/node-tap/issues/422
+const t = require('../')
+t.test('just a lot of asserts in rapid succession', t => {
+  for (let i = 0; i < 5000; i++) {
+    t.pass('a number is ' + i)
+  }
+  t.end()
+})

Original file line number	Diff line number	Diff line change
`@@ -9,9 +9,9 @@ const _didPipe = Symbol('_didPipe')`
`9`	`9`
`10`	`10`	`const monkeypatchEpipe = () => {`
`11`	`11`	`const emit = process.stdout.emit`
`12`		`- process.stdout.emit = (ev, er) => {`
	`12`	`+ process.stdout.emit = function (ev, er) {`
`13`	`13`	`if (ev !== 'error' \|\| er.code !== 'EPIPE')`
`14`		`- return emit.apply(process, arguments)`
	`14`	`+ return emit.apply(process.stdout, arguments)`
`15`	`15`	`}`
`16`	`16`	`}`
`17`	`17`