forked from astropy/astropy
-
Notifications
You must be signed in to change notification settings - Fork 3
Implement mixin columns using class attribute for compatibility #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfa1e9e to
3417171
Compare
0009929 to
f9c61b4
Compare
3417171 to
373e453
Compare
a4d5b7f to
0543479
Compare
37d6324 to
99aa068
Compare
9407b1b to
c1b563c
Compare
c55883c to
a7a9dbc
Compare
…issue-3029 Rename beta1d and beta2d - solves issue 3029 (This takes over astropy#3102)
parameter descriptors does not work yet.
…le output models.
… a True-like value, so ensure that we actually get a float when a float result is expected.
…creating new model classes with custom names.
…s. In retrospect it should have been blatantly obvious that was a bad idea, and unnecessary anyways. Turns out Python creates a new method object every time you access a method on an object anyways (this is still reasonably efficient, as it uses a cache of already malloc'd PyMethodObjects and just updates the im_func and im_self pointers on those objects).
…erly support parameterless models here.
…om for improvement here but this is a start.
…y expression. This requires one input which is a mapping of operators to a numerical precedence so that the correct order of operations can be determined. This ended up looking a lot like ExpressionTree.evaluate, which might be able to be used to implement this with a little refactoring.
…afs. This method still needs more work though :/
…il the enhancements to the tree display are complete.
… a new instance is returned, rather than the class itself. If the class is for some reason needed it can still be gotten at, but in most cases it seems to be clearer if we just return an instance.
c744936 to
6ae6e65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.