Skip to content

fix: TestMavenRuntime5/AbstractTestMavenRuntime depend JUnit4#90

Merged
cstamas merged 1 commit intotakari:masterfrom
sebthom:patch-1
Sep 10, 2024
Merged

fix: TestMavenRuntime5/AbstractTestMavenRuntime depend JUnit4#90
cstamas merged 1 commit intotakari:masterfrom
sebthom:patch-1

Conversation

@sebthom
Copy link
Copy Markdown
Contributor

@sebthom sebthom commented Sep 7, 2024

When excluding JUnit4 when using JUnit 5 like:

      <dependency>
         <groupId>io.takari.maven.plugins</groupId>
         <artifactId>takari-plugin-testing</artifactId>
         <version>3.0.4</version>
         <scope>test</scope>
         <exclusions>
            <exclusion>
               <groupId>junit</groupId>
               <artifactId>junit</artifactId>
            </exclusion>
         </exclusions>
      </dependency>

the build fails with:

java.lang.NoClassDefFoundError: org/junit/rules/TestRule
        at java.base/java.lang.ClassLoader.defineClass1(Native Method)
        at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1022)
        at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:174)
        at java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:800)
        at java.base/jdk.internal.loader.BuiltinClassLoader.findClassOnClassPathOrNull(BuiltinClassLoader.java:698)
        at java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:621)
        at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:579)
        at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:527)
        at io.takari.maven.testing.AbstractTestMavenRuntime.<clinit>(AbstractTestMavenRuntime.java:42)

Because AbstractTestMavenRuntime references the JUnit4 TestMavenRuntime class.

@cstamas cstamas merged commit 8efeb95 into takari:master Sep 10, 2024
@sebthom sebthom deleted the patch-1 branch September 16, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sebthom @cstamas