fix: avoid infinite loop for square brackets custom modifier#167
fix: avoid infinite loop for square brackets custom modifier#167adamwathan merged 1 commit intotailwindlabs:mainfrom
Conversation
|
Can confirm this fixes the infinite loop: #168 But since my own styles are still not showing correct I am unable to confirm that this fixes the issue and doesn't create a new one. |
|
@u12206050 What styles aren't working for you so I can test it? They worked in v0.1.11? |
|
Thanks so much for the PR, merged! I've removed the charCode bit just to make this the simplest possible change necessary to fix the open issues because I wasn't sure I understood what it was solving — can you tell me more about what issue that solves? Just want to make sure I understand before I blindly merge that part in 👍🏻 Thanks again! |
|
@adamwathan Thanks, after using this code it is the first time I actually get to view my site using tailwind jit. |
|
Hmm can't reproduce, if you can create a new issue with a reproduction repository that demonstrates the problem happy to look 👍🏻 |
|
@fedeci Nevermind I understand now! Thanks again 👊 |
|
I created a new project from scratch just to double check and things work fine, so is just something wrong with my postcss/webpack 5 setup. |
Fixes #165 and fixes #166 and fixes #168
We check for square brackets at the end of the string only on the first iteration to avoid infinite loops.
Furthermore we correctly return
prefixandmodifierfor: