Fix crash when formatting svelte files that have "let:class".#24
Merged
bradlc merged 2 commits intotailwindlabs:mainfrom Jan 27, 2022
Merged
Fix crash when formatting svelte files that have "let:class".#24bradlc merged 2 commits intotailwindlabs:mainfrom
bradlc merged 2 commits intotailwindlabs:mainfrom
Conversation
Contributor
|
Thank you! |
bronisMateusz
pushed a commit
to bronisMateusz/prettier-plugin-tailwindcss-drupal
that referenced
this pull request
Apr 16, 2025
…ndlabs#24) * Add tests for svelte's let directive. * Avoid formatting svelte's let directive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there, I encountered a crash when running the plugin on a svelte file that has a slot component like this:
Below was the error message and I've got a repro here:
I found that the plugin was trying to read the "value" attribute from the let directive, which is always undefined. So to avoid this, I added a check to make sure that the sorting only runs on the class attributes, not on a directive named class such as
let:class={className}.