Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vite has an
optimizeDepspass that does not like that you can't import from@heroicons/reactor@heroicons/vuedirectly. This is because we do not have amain/module/exports."."entry in our package.json. This was intentional because such an import is invalid. You must import from one of:@heroicons/react/20/solid@heroicons/react/24/solid@heroicons/react/24/outline@heroicons/vue/20/solid@heroicons/vue/24/solid@heroicons/vue/24/outlineHowever, because of this problem we need one to exist for Vite to not break if it decides to optimize deps and include
@heroicons/react(or@heroicons/vue) either because there's many packages, because the user has forced them on for all packages, or it's been explicitly included by the user.This PR solves this by adding root-level entry points for
@heroicons/reactand@heroicons/vue. If someone tries to use these imports directly we will throw an error at runtime letting them know the correct path(s) to import.Fixes #934