Make sure calls to forwardRef are marked as pure#1192
Merged
thecrypticace merged 2 commits intomasterfrom Jun 17, 2024
Merged
Conversation
RobinMalfait
approved these changes
Jun 17, 2024
Member
RobinMalfait
left a comment
RobinMalfait
left a comment
There was a problem hiding this comment.
Looks good! Shall we do a patch release for this one?
Contributor
Author
|
sweet — yeah let's do a patch for this one |
This was referenced Jul 9, 2024
This was referenced Aug 1, 2024
This was referenced Sep 21, 2024
This was referenced Sep 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React.forwardRefshould always be marked as pure and doing so can help with tree shaking in some build tools.Fixes #1171