ipn, cmd/tailscale/cli: add pref to configure sudo-free operator user - #1722
Merged
Conversation
bradfitz
force-pushed
the
bradfitz/allow
branch
from
April 17, 2021 05:05
f2f6948 to
f342aec
Compare
danderson
approved these changes
Apr 17, 2021
|
|
||
| // OperatorUser is the local machine user name who is allowed to | ||
| // operate tailscaled without being root or using sudo. | ||
| OperatorUser string `json:",omitempty"` |
Member
There was a problem hiding this comment.
Make []string? Would be nice to be able to grant tailscale use to multiple operators, maybe? Unsure.
Member
Author
There was a problem hiding this comment.
We could keep it simple now and support comma-delimited in the future if we want to add that later?
Member
Author
There was a problem hiding this comment.
Also, once we get to wanting to support multiple operators, that starts to sound like a group to me.
So I don't want to make this overly complicated for now. Let's address the common case (single user, single admin) and deal with the Enterprise Management Solutions(tm) later once needs are understood.
From discussion with @danderson. Fixes #1684 (in a different way) Signed-off-by: Brad Fitzpatrick <[email protected]>
bradfitz
force-pushed
the
bradfitz/allow
branch
from
April 19, 2021 16:50
f342aec to
633e07a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From discussion with @danderson.
Fixes #1684 (in a different way)