types/netmap,wgengine/magicsock: propagate CapVer to magicsock.endpoint#16244
Merged
types/netmap,wgengine/magicsock: propagate CapVer to magicsock.endpoint#16244
Conversation
This enables us to mark nodes as relay capable or not. We don't actually do that yet, as we haven't established a relay CapVer. Updates tailscale/corp#27502 Signed-off-by: Jordan Whited <[email protected]>
Pull Request Revisions
✅ AI review completed for r1 HelpReact with emojis to give feedback on AI-generated reviews:
We'd love to hear from you—reach out anytime at [email protected]. |
ghost
reviewed
Jun 11, 2025
danderson
approved these changes
Jun 11, 2025
Member
|
keep in mind that these aren’t plumbed to server side yet either, so you’ll have to do that as well. The current ones on the wire are faked to be close enough for old needs. |
jwhited
added a commit
that referenced
this pull request
Jun 19, 2025
…k.endpoint (#16244)" This reverts commit 6a93b17. The reverted commit added more complexity than it was worth at the current stage. Handling delta CapVer changes requires extensive changes to relayManager datastructures in order to also support delta updates of relay servers. Updates tailscale/corp#27502
jwhited
added a commit
that referenced
this pull request
Jun 19, 2025
…k.endpoint (#16244)" This reverts commit 6a93b17. The reverted commit added more complexity than it was worth at the current stage. Handling delta CapVer changes requires extensive changes to relayManager datastructures in order to also support delta updates of relay servers. Updates tailscale/corp#27502 Signed-off-by: Jordan Whited <[email protected]>
jwhited
added a commit
that referenced
this pull request
Jun 19, 2025
…k.endpoint (#16244)" (#16322) This reverts commit 6a93b17. The reverted commit added more complexity than it was worth at the current stage. Handling delta CapVer changes requires extensive changes to relayManager datastructures in order to also support delta updates of relay servers. Updates tailscale/corp#27502 Signed-off-by: Jordan Whited <[email protected]>
davidsbond
pushed a commit
that referenced
this pull request
Jun 30, 2025
…k.endpoint (#16244)" (#16322) This reverts commit 6a93b17. The reverted commit added more complexity than it was worth at the current stage. Handling delta CapVer changes requires extensive changes to relayManager datastructures in order to also support delta updates of relay servers. Updates tailscale/corp#27502 Signed-off-by: Jordan Whited <[email protected]>
ChandonPierre
pushed a commit
to coreweave/tailscale
that referenced
this pull request
Sep 3, 2025
…nt (tailscale#16244) This enables us to mark nodes as relay capable or not. We don't actually do that yet, as we haven't established a relay CapVer. Updates tailscale/corp#27502 Signed-off-by: Jordan Whited <[email protected]>
ChandonPierre
pushed a commit
to coreweave/tailscale
that referenced
this pull request
Sep 3, 2025
…k.endpoint (tailscale#16244)" (tailscale#16322) This reverts commit 6a93b17. The reverted commit added more complexity than it was worth at the current stage. Handling delta CapVer changes requires extensive changes to relayManager datastructures in order to also support delta updates of relay servers. Updates tailscale/corp#27502 Signed-off-by: Jordan Whited <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables us to mark nodes as relay capable or not. We don't actually do that yet, as we haven't established a relay CapVer.
Updates tailscale/corp#27502