Repository navigation
fix(deps): pin html2md to 0.2.15 to fix android build - #3949
Merged
Merged
Conversation
github-actions
Bot
added
the
type: fix
amitksingh1490
added
the
ci: build all targets
amitksingh1490
removed
the
ci: build all targets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on main fails in
build-release (aarch64-linux-android)(run 36548127453): html2md 0.2.16/0.2.17 depend onjni ^0.22for Android but still call the removed 0.21 API (get_string/new_stringonEnvUnowned), so the crate doesn't compile for Android targets. html2md 0.2.17 came in with the lockfile refresh in #3913.Pins
html2md = "=0.2.15"(jni 0.19) until upstream fixes it. Note this also downgrades html2md's parser stack (html5ever 0.39 -> 0.27, markup5ever_rcdom, tendril, xml5ever), so HTML-to-markdown output could differ slightly.