Conversation
|
I wish it was easily reproducible. It currently only happens occasionally, so not sure how to test it exactly other than running in a loop many times and getting higher and higher probability of the issue being fixed. |
|
Indeed, that’s true... For now, it might be better to release this as is and have people test it, and then have them report issues in this PR when they still occur. |
f712165 to
f399759
Compare
|
Thanks for trying to fix this, I'll revert our workaround and report if we find any issues ❤️ |
|
Published in 2.71.0. |
|
It did fail properly the very first time I tried the latest release: https://github.com/nazar-pc/abundance/actions/runs/23874204770/job/69613321738?pr=615 However, I'd appreciate if there were any logs shown at all that hint at the problem. Previously it quietly succeeded even when there was a failure, now it at least explicitly fails, but still quietly. |
|
Thanks for testing this and reporting the issue! I'll implement retry (and logging). |
|
Filed #1657 to implement retry and logging. |
|
Published 2.71.2 which includes the above fix. |
|
Thank you! |
3 participants
Workaround for windows-11-arm runner bug: actions/runner-images#14052.
Fixes #1645
Fixes #1562
Fixes #1472
The issue appears to be bash sometimes failing to start either due to how GHA launches bash or regardless of who to launch bash.
In the former case, just calling bash from powershell should be sufficient (as currently implemented in this PR); in the latter case, I think it would be sufficient to add a way to detect whether bash failed to start (such as creating and checking a temporary file) and then retry a few times.
I haven't encountered this issue in my repositories yet, so it's difficult for me to test whether the former approach is sufficient. (For now, I plan to continually rerun the tests using the windows-11-arm runner in this PR.)
I would appreciate it if anyone who has encountered this issue could help with testing.
cc @wmmc88 @nazar-pc @NobodyXu @deivid-rodriguez