Implement read_text_into() and read_text_into_async()#941
Merged
Mingun merged 7 commits intotafia:masterfrom Feb 20, 2026
Merged
Implement read_text_into() and read_text_into_async()#941Mingun merged 7 commits intotafia:masterfrom
read_text_into() and read_text_into_async()#941Mingun merged 7 commits intotafia:masterfrom
Conversation
…_ref` and `read_text` (review with with whitespace ignored mode)
…nd XML declarations
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #941 +/- ##
==========================================
- Coverage 58.08% 54.99% -3.10%
==========================================
Files 42 44 +2
Lines 15513 16869 +1356
==========================================
+ Hits 9011 9277 +266
- Misses 6502 7592 +1090
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
I realized, that actually need to return |
Copy and adapt tests in tests/ directory from borrowed variant Copy фотв adapt documentation of new methods from the read_text methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes buffered readers in that way that
bufwill now populated with the>and;characters (closing character of a markup and a general entity reference). Previously they do not included in the buffer because events does not use them, that's created difficulties when we wanted to read markup data as a string.Previous PR #936 enables inclusion of
<character to the buffer, so now all data is included and we can finally implement #483 for buffered readers.Fixes #483