Fix parsing error of the tag from buffered reader, when the first byte < is the last in the internal buffer of BufRead#940
Conversation
…have `<` in input Currently those methods are called when position points to `<` in XML source, so test them in that environment
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #940 +/- ##
==========================================
- Coverage 58.08% 55.00% -3.09%
==========================================
Files 42 44 +2
Lines 15513 16816 +1303
==========================================
+ Hits 9011 9249 +238
- Misses 6502 7567 +1065
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| /// Regression test for https://github.com/tafia/quick-xml/issues/939 | ||
| #[test] | ||
| fn issue939() { |
There was a problem hiding this comment.
It would be nice if these would have a short note on what was being tested, apart from the issue number. But given that's the current pattern for this file, this isn't a blocking request.
There was a problem hiding this comment.
It's never too late to start. I added an explanation of the test
failures:
issue939
…kup methods That is: - read_bang_element - read_element In next commit buffered readers will require to skip the first byte because it will be consumed in peek_one Slice reader does not require and cannot consume that byte
…e `<` is the last in the BufRead internal buffer
3 participants
Fixes #939 which is regression from #936