Fix incorrect result of .read_text() when it is called after reading Text or GeneralRef event#936
Merged
Mingun merged 3 commits intotafia:masterfrom Feb 14, 2026
Merged
Conversation
failures:
borrowed::dangling_amp
borrowed::text
Diff < left / right > :
<"root/><root></root><"
>"<root/><root></root>"
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #936 +/- ##
==========================================
- Coverage 58.08% 54.98% -3.10%
==========================================
Files 42 44 +2
Lines 15513 16789 +1276
==========================================
+ Hits 9011 9232 +221
- Misses 6502 7557 +1055
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dralley
approved these changes
Feb 14, 2026
This was referenced Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found, that due to that we read text and ref data, we skip
<at the end of text. Because it is skipped, reading text via.read_text()returns wrong slice:This PR fixes this bug and opens door for #483