Split SyntaxError::UnclosedTag into UnclosedTag and UnclosedAttributeValue#932
Split SyntaxError::UnclosedTag into UnclosedTag and UnclosedAttributeValue#932Mingun merged 1 commit intotafia:masterfrom
SyntaxError::UnclosedTag into UnclosedTag and UnclosedAttributeValue#932Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #932 +/- ##
==========================================
- Coverage 58.08% 54.55% -3.53%
==========================================
Files 42 44 +2
Lines 15513 16914 +1401
==========================================
+ Hits 9011 9228 +217
- Misses 6502 7686 +1184
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/errors.rs
Outdated
| /// | ||
| /// Note, that currently error location will point to a start of a tag (the `<` character) | ||
| /// instead of a start of an attribute value. | ||
| UnclosedAttributeValue(bool), |
There was a problem hiding this comment.
IMO an enum type would be preferable to bool
There was a problem hiding this comment.
I thinked about UncloseSingleQuotedAttributeValue and UncloseDoubleQuotedAttributeValue instead of one variant. It seems to me that no need to introduce UnclosedAttributeValue(enum QuoteType), because QuoteType seems will be used only here, and errors usually anyway will be just passed above.
So I can change as described, agree?
…uotedAttributeValue` and `UnclosedDoubleQuotedAttributeValue` for more precise error reporting
Mingun
force-pushed
the
unclosed-attr-error
branch
from
9125d00 to
229d84c
Compare
3 participants
For more precise error reporting.
Closes #926.
Currently error is reported at start of a tag instead of start of an attribute value.