Split SyntaxError::UnclosedPIOrXmlDecl into separate enum variants#924
Conversation
|
I will do my best to address reviews as fast as I can. Once this is merged, I would appreciate a new release very much :) |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #924 +/- ##
==========================================
- Coverage 58.08% 58.06% -0.02%
==========================================
Files 42 42
Lines 15513 15552 +39
==========================================
+ Hits 9011 9031 +20
- Misses 6502 6521 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mingun
left a comment
Mingun
left a comment
There was a problem hiding this comment.
Probably, that the right way to do that. I haven't looked in detail yet, but I already see a problem with the potential handling of currently unsupported encodings. I would like to see at least #[ignore]d tests added for these cases and FIXMEs in problematic lines.
Also, such change needs changelog entry. I prefer if you rebase your branch over current master instead of merging (that is needed to prevent merge conflict in Changelog.md).
SuchAFuriousDeath
force-pushed
the
unclosed-xml-decl-pi-split
branch
from
3388f3c to
cf62324
Compare
Mingun
force-pushed
the
unclosed-xml-decl-pi-split
branch
from
cf62324 to
e9ad237
Compare
|
Thanks! |
3 participants
Implements #916
The SyntaxError enum is public, so this is a breaking change.
The Parser trait is also public, so the method signature change is also a breaking change.