Optionally add a space before the trailing slash in unexpanded empty elements#922
Merged
Mingun merged 2 commits intotafia:masterfrom Dec 21, 2025
Merged
Optionally add a space before the trailing slash in unexpanded empty elements#922Mingun merged 2 commits intotafia:masterfrom
Mingun merged 2 commits intotafia:masterfrom
Conversation
…ace before `/>` in self-closed tags
…in unexpanded empty elements
Mingun
force-pushed
the
space-before-slash
branch
from
e8e6f68 to
b90476e
Compare
Collaborator
|
I simplified |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #922 +/- ##
=======================================
Coverage 58.08% 58.08%
=======================================
Files 42 42
Lines 15513 15537 +24
=======================================
+ Hits 9011 9025 +14
- Misses 6502 6512 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mingun
added a commit
to Mingun/quick-xml
that referenced
this pull request
Jan 11, 2026
Fixes warnings in `cargo doc --all-features --document-private-items`: warning: unresolved link to `Self::expand_empty_elements` --> src\se\content.rs:53:42 | 53 | /// Usage of empty tags depends on the [`Self::expand_empty_elements`] setting. | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ the struct `ContentSerializer` has no field or associated item named `expand_empty_elements` | = note: `#[warn(rustdoc::broken_intra_doc_links)]` on by default warning: unresolved link to `ContentSerializer::expand_empty_elements` --> src\se\element.rs:58:42 | 58 | /// Usage of empty tags depends on the [`ContentSerializer::expand_empty_elements`] setting. | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the struct `ContentSerializer` has no field or associated item named `expand_empty_elements`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #846.
There are changes for both the writer (via a new
Configstruct) and the serializer, and I think there should be sufficient coverage via doc tests.This is a breaking change for the serializer, replacing
ser.expand_empty_elements(true);withser.set_empty_element_handling(EmptyElementHandling::Expanded);.