Improve API of Attributes::has_nil and deprecate some methods for namespace resolution#913
Improve API of Attributes::has_nil and deprecate some methods for namespace resolution#913Mingun merged 2 commits intotafia:masterfrom
Attributes::has_nil and deprecate some methods for namespace resolution#913Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #913 +/- ##
==========================================
+ Coverage 58.08% 58.21% +0.12%
==========================================
Files 42 42
Lines 15513 15479 -34
==========================================
Hits 9011 9011
+ Misses 6502 6468 -34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/reader/ns_reader.rs
Outdated
| /// # quick_xml::Result::Ok(()) | ||
| /// ``` | ||
| #[inline] | ||
| #[deprecated = "Use `.resolver().bindings()` instead"] |
There was a problem hiding this comment.
If you have a concrete idea of which release it will be removed in completely, it might be good to list that. Up to you.
However either there should be an issue filed to remove the deprecated bits.
There was a problem hiding this comment.
If you have a concrete idea of which release it will be removed in completely, it might be good to list that.
Yes, it will be good addition. It will be next minor. I already have a commit that actually removes them. I could open such PR immediately.
…resolve_element()` of `NsReader` Use `NamespaceResolver` methods instead of `NsReader` methods
3 participants
No description provided.