Remove usage of deprecated serde_if_integer128 and bump serde dependecy#908
Merged
Mingun merged 1 commit intotafia:masterfrom Nov 11, 2025
Merged
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #908 +/- ##
==========================================
+ Coverage 55.52% 58.08% +2.55%
==========================================
Files 42 42
Lines 15511 15513 +2
==========================================
+ Hits 8613 9011 +398
+ Misses 6898 6502 -396
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
I do not like to bump dependencies in patch releases so hold this until minor release. I did not look at #904 yet, so if it go into patch, I'll merge it first. |
Mingun
force-pushed
the
remove-serde_if_integer128
branch
from
cb34329 to
63330b8
Compare
…ncy >=1.0.139 -> >=1.0.180 due to that
Mingun
force-pushed
the
remove-serde_if_integer128
branch
from
63330b8 to
d1acdb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serde 1.0.221 deprecated
serde_if_integer128macro, which leads to warnings when compile quick-xml. That macro does nothing since serde 1.0.187, and since 1.0.180 serde requires compiler >=1.26 which stabilizes 128-bit integers.So it seems that it is enough to require serde >=1.0.180