Allow attributes in the xml namespace to roundtrip with serde#873
Merged
Mingun merged 1 commit intotafia:masterfrom Jun 28, 2025
Merged
Allow attributes in the xml namespace to roundtrip with serde#873Mingun merged 1 commit intotafia:masterfrom
xml namespace to roundtrip with serde#873Mingun merged 1 commit intotafia:masterfrom
Conversation
Mingun
added
serde
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #873 +/- ##
==========================================
- Coverage 60.74% 58.33% -2.42%
==========================================
Files 41 42 +1
Lines 16044 17118 +1074
==========================================
+ Hits 9746 9985 +239
- Misses 6298 7133 +835
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mingun
force-pushed
the
serde_roundtrip_xml_attrs
branch
from
5d41f9b to
bc18c57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #841.
When deserializing attribute names, this version prevents the
xml:namespace prefix to be split off.I am admittedly not familiar with XML namespaces at all and have taken this reasoning at face value. If this is not a desirable feature after all, please let me know!