Conversation
Mingun
left a comment
Mingun
left a comment
There was a problem hiding this comment.
Bumping dev-dependencies would be fine, but we do not expect that for dependencies. That is minimal supported versions and until we use newer features of those dependencies they should left the same. The final application will pick the most recent allowed version and we do not want to artificially raise that numbers.
Because when built cargo will use latest versions withing semver, it is not necessary to raise dev-dependencies too except for criterion which I wanted to update many times. I not against raising them, but don't know how this will influence our minimal-versions workflow. It has a chance that it will not able to build, but we can check that. Please, revert dependencies table and we try to run workflows.
|
I prefer never to update by myself, but to use the tools like |
|
Removed all lines except criterion which has been stood out too much for me |
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #870 +/- ##
==========================================
- Coverage 60.74% 58.53% -2.22%
==========================================
Files 41 42 +1
Lines 16044 17066 +1022
==========================================
+ Hits 9746 9989 +243
- Misses 6298 7077 +779
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
|
A note about failing MSRV: if you expect that an example app will work with your library with a given version, do exactly that. |
Mingun
force-pushed
the
bump-versions
branch
4 times, most recently
from
21ad90c to
6c62770
Compare
3 participants
Built and tested,
please note: I haven't run benches or MSRV check locally
criterion::black_boxis replaced to follow directions in deprecation messageDeprecated: use std::hint::black_box() instead