Add ability to deserialize from Attributes#863
Merged
dralley merged 7 commits intotafia:masterfrom May 9, 2025
Merged
Conversation
…use it is always true
…ccess The responsibility for customizing prefixes on ElementMapAccess.
It is private type, because it is not re-exported from private `key` module
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #863 +/- ##
==========================================
+ Coverage 60.21% 60.54% +0.33%
==========================================
Files 41 42 +1
Lines 16021 16078 +57
==========================================
+ Hits 9647 9735 +88
+ Misses 6374 6343 -31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dralley
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds ability to convert
Attributesiterator into a serde'sMapAccessandDeserializer, so it will be easely to mix serde-based and reader-based approaches.The implementation will require to move
Decoderinto theAttributesand, as a consequence, toBytesStart. That is already was required for other purposes, but this will increase the size of both structs by 8 bytes. I still think it is a fair price for the benefits.