Simplify Deserializer::peek to avoid unreachable#860
Merged
Mingun merged 1 commit intotafia:masterfrom May 5, 2025
Merged
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #860 +/- ##
==========================================
+ Coverage 60.21% 60.74% +0.53%
==========================================
Files 41 41
Lines 16021 16044 +23
==========================================
+ Hits 9647 9746 +99
+ Misses 6374 6298 -76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mingun
approved these changes
May 4, 2025
Collaborator
Mingun
left a comment
Mingun
left a comment
There was a problem hiding this comment.
Good catch. Just add missing comma and I merge it.
Use `Option::insert` which allows getting a reference to the value just inserted into the Option. Unfortunately, we can't simplify this to just `Option::get_or_insert_with` because we can fail to generate the value to insert (if reader.next() fails).
Dr-Emann
force-pushed
the
push-oqkoknnmvqxm
branch
from
be41ced to
254fbd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
Option::insertwhich allows getting a reference to the value just inserted into the Option.Unfortunately, we can't simplify this to just
Option::get_or_insert_withbecause we can fail to generate the value to insert (if reader.next() fails).