Skip to content

Comments

Derive implementations#852

Merged
Mingun merged 4 commits intotafia:masterfrom
Numix-AB:derive-implementations
Mar 31, 2025
Merged

Derive implementations#852
Mingun merged 4 commits intotafia:masterfrom
Numix-AB:derive-implementations

Conversation

@lukasfri
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.47%. Comparing base (a9391f3) to head (9a91306).
Report is 37 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #852      +/-   ##
==========================================
+ Coverage   60.21%   60.47%   +0.26%     
==========================================
  Files          41       41              
  Lines       16021    16112      +91     
==========================================
+ Hits         9647     9744      +97     
+ Misses       6374     6368       -6     
Flag Coverage Δ
unittests 60.47% <ø> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lukasfri
Copy link
Contributor Author

I seem to accidentally have published this PR a bit early, I planned on making some more improvements to the NsReader to justify this PR, but personally I really only need Clone implemented for my own uses, and added Debugs due to me not seeing any reason why they wouldn't be implemented.

@Mingun
Copy link
Collaborator

Mingun commented Mar 30, 2025

Yes, I agree that the lack of implementation of those traits is an oversight. If you plan to add something to this PR, please also add a changelog entry about added trait implementations

@lukasfri
Copy link
Contributor Author

@Mingun Done. I'll leave any other future changes in another PR.

@lukasfri
Copy link
Contributor Author

Sorry, I don't know how I accidentally wrote the wrong PR number. That's dumb.

@Mingun Mingun merged commit cbcf835 into tafia:master Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants