Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #852 +/- ##
==========================================
+ Coverage 60.21% 60.47% +0.26%
==========================================
Files 41 41
Lines 16021 16112 +91
==========================================
+ Hits 9647 9744 +97
+ Misses 6374 6368 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I seem to accidentally have published this PR a bit early, I planned on making some more improvements to the NsReader to justify this PR, but personally I really only need Clone implemented for my own uses, and added Debugs due to me not seeing any reason why they wouldn't be implemented. |
|
Yes, I agree that the lack of implementation of those traits is an oversight. If you plan to add something to this PR, please also add a changelog entry about added trait implementations |
|
@Mingun Done. I'll leave any other future changes in another PR. |
Co-authored-by: Mingun <[email protected]>
|
Sorry, I don't know how I accidentally wrote the wrong PR number. That's dumb. |
No description provided.