Resolve "xs:list deserialization does not split on all whitespace"#843
Resolve "xs:list deserialization does not split on all whitespace"#843JGM01 wants to merge 6 commits intotafia:masterfrom
Conversation
…rious types of possible delimiters.
Mingun
left a comment
Mingun
left a comment
There was a problem hiding this comment.
Thanks for PR. I would like to have:
- a new test that ensures that bug is fixed
- a changelog entry informing users that bug is fixed
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #843 +/- ##
==========================================
- Coverage 58.08% 54.54% -3.54%
==========================================
Files 42 44 +2
Lines 15513 16945 +1432
==========================================
+ Hits 9011 9243 +232
- Misses 6502 7702 +1200
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Sorry for necro but has this been looked at? Was just looking through my old repos and saw the fork. |
|
It in my short list. Probably I'll implement other solution based on #379, but until that, let it remain open. |
4 participants
Changed DELIMITER (u8) into an array DELIMITERS (u8; 4) that holds 4 possible delimiters.
This was implemented with issue #839 in mind, so I covered the following whitespaces:
\t,\r,\n. It is fairly easy to include more if necessary.