Have read_namespace_event borrow the ns buffer#69
Merged
Conversation
The current situation, where the reader owns the namespace buffer leads to a bad api. Indeed in the inner loop of the `read_namespaced_event`, the reader, mutably borrowed cannot be used. Making the caller own the buffer fixes the situation, while still avoiding extra allocation.
Owner
Author
|
Published v0.8.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current situation, where the reader owns the namespace buffer leads to an inconvenient api.
In the inner loop of the
read_namespaced_event, the reader, mutably borrowed cannot be used, notably for decoding the event. The workaround, having temporary variables is not satisfactory (more boilerplate and additional checks).Making the caller own the buffer fixes the situation, while still avoiding extra allocation.
See #68