Fix incorrect behaviour of сheck_end_names after disabling and enabling#516
Merged
dralley merged 3 commits intotafia:masterfrom Nov 28, 2022
Hidden character warning
The head ref may contain hidden characters: "fix-\u0441heck-end-names"
Merged
Fix incorrect behaviour of сheck_end_names after disabling and enabling#516dralley merged 3 commits intotafia:masterfrom
сheck_end_names after disabling and enabling#516dralley merged 3 commits intotafia:masterfrom
Conversation
failures (2):
---- issue514::no_mismatch stdout ----
thread 'issue514::no_mismatch' panicked at 'called `Result::unwrap()` on an `Err` value: EndEventMismatch { expected: "html", found: "some-tag" }', tests\issues.rs:34:40
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
---- issue514::mismatch stdout ----
thread 'issue514::mismatch' panicked at 'assertion failed: `(left == right)`
Diff < left / right > :
<html
>some-tag
', tests\issues.rs:59:17
Codecov Report
@@ Coverage Diff @@
## master #516 +/- ##
==========================================
+ Coverage 61.33% 61.38% +0.04%
==========================================
Files 33 33
Lines 15393 15397 +4
==========================================
+ Hits 9441 9451 +10
+ Misses 5952 5946 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dralley
approved these changes
Nov 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since now are always track stack of names, regardless of
сheck_end_namessetting. This is also fixes an error when you start from disabled setting, read some open tag and then enable reporting. After this PR that error will be correctly reported if closed tag won't match opened.Fixes #514