Fix deserialization of top-level sequences of enums#501
Merged
dralley merged 3 commits intotafia:masterfrom Oct 30, 2022
Merged
Fix deserialization of top-level sequences of enums#501dralley merged 3 commits intotafia:masterfrom
dralley merged 3 commits intotafia:masterfrom
Conversation
… field annotated with `#[serde(rename = "$value")]`
It is too small and trivial to keep it in its own file
Mingun
added
bug
serde
Codecov Report
@@ Coverage Diff @@
## master #501 +/- ##
==========================================
- Coverage 61.70% 61.61% -0.10%
==========================================
Files 33 32 -1
Lines 15343 15307 -36
==========================================
- Hits 9468 9432 -36
Misses 5875 5875
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dralley
reviewed
Oct 30, 2022
dralley
reviewed
Oct 30, 2022
dralley
reviewed
Oct 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #500. The behavior of top-level sequence actually very simple -- try to deserialize until
Eofis received, which is the only stop marker.After the fix in the first commit it became obvious, that some refactoring could be done to put highly coupled code together, which is done in the next 2 commits.