Rewrite serializer by Mingun · Pull Request #490 · tafia/quick-xml

Mingun · 2022-10-01T20:57:38Z

This PR rewrites serializer and fixes the following issues:

Fixes Help serializing empty attributes #252
Fixes Vec<String> inside of struct serializes incorrectly with serde #280
Fixes How to have tag on each item? #287
Fixes Serialization of Hashmap duplicate outer tag in the inners elements. Deserialization has no such problem and fails on serialized xml. #343
Fixes Serialization of enums adds extra tags #346
Invalidates Deserializing $primitive= unit variants doesn't work correctly yet #354 (but it still should be checked that it works aligned with the serializer)
Fixes How to pretty-print with serde? #361
Partially addresses Handling of control characters #368
Fixes Serializing $value enum variant doesn't work #429
Fixes Use $value and $unflatten together #430

Notable changes:

Removed $unflatten= prefix, as it not used anymore
Removed $primitive= prefix, as it not used anymore
$value special name split into two special names #text and ~~#any~~ #content. @dralley, please check especially, is the documentation clear about the differences?
Change how attributes is defined. Now attribute should have a name started with @ character. Without that fields serialized as elements and can be deserialized only from elements. Deserialization from element or from attribute into one field is not possible anymore. It's a weird wish anyway

codecov-commenter · 2022-10-01T21:12:28Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 88.24228% with 198 lines in your changes missing coverage. Please review.

Project coverage is 61.66%. Comparing base (7c423ce) to head (8b50c64).
Report is 588 commits behind head on master.

Files with missing lines	Patch %	Lines
src/de/mod.rs	4.25%	135 Missing ⚠️
src/se/mod.rs	83.87%	20 Missing ⚠️
src/se/simple_type.rs	98.04%	13 Missing ⚠️
src/se/content.rs	97.20%	12 Missing ⚠️
src/de/key.rs	96.75%	7 Missing ⚠️
src/de/map.rs	53.84%	6 Missing ⚠️
src/escapei.rs	62.50%	3 Missing ⚠️
src/de/simple_type.rs	98.48%	1 Missing ⚠️
src/writer.rs	88.88%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #490      +/-   ##
==========================================
+ Coverage   54.16%   61.66%   +7.50%     
==========================================
  Files          30       33       +3     
  Lines       12649    15343    +2694     
==========================================
+ Hits         6851     9462    +2611     
- Misses       5798     5881      +83

Flag	Coverage Δ
unittests	`61.66% <88.24%> (+7.50%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/errors.rs

src/se/key.rs

tests/test.rs

Changelog.md

dralley · 2022-10-02T04:27:24Z

+6,885 −1,917

I might need a few days for this

rrichardson · 2022-10-07T19:40:58Z

How does one achieve the previous behavior of enums where the enum value would be wrapped in the enum type tag?

enum Wat {
    Foo,
    Bar,
    Baz
} 
struct Test {
    wat: Wat, 
}

results in

<Test>
    <Foo/> 
</Test>

and if you add rename=#text to wat: Wat then you get

<Test>
    Foo
</Test>

Is the intention that we wrap the enum in a wrapper struct if we want type tags for the enum?

<Test> 
    <Wat>Foo</Wat> 
</Test>

I guess this makes it consistent with the way lists are handled, and also consistent with the philosophical standpoint that enum is simply one of N possible values, and not a container.

We should probably document this change, though.

rrichardson · 2022-10-07T22:12:41Z

It appears that the #text or #any attributes are required if you want to successfully deserialize an enum from a struct. I'm assuming that this is because the outer type tags of the enum are eaten, so we need to tell the deserializer exactly how to parse the contents.

mod try_enum {
    use quick_xml::{de::from_str, se::to_string};
    use serde::{Deserialize, Serialize};
    
    #[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)]
    enum WatEnum {
        #[serde(rename="FOO")]
        Foo,
        #[serde(rename="BAR")]
        Bar,
        #[serde(rename="BAZ")]
        Baz
    }

    #[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)]
    struct Wat {
        wat: WatEnum
    }

    #[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)]
    struct Wat2 {
        #[serde(rename="#any")]
        wat: WatEnum
    }

    #[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)]
    struct Wat3 {
        #[serde(rename="#text")]
        wat: WatEnum
    }

    #[test]  // This fails
    fn round_trip_enum_none() {
        let tst = Wat { wat: WatEnum::Bar };
        let data = to_string(&tst).unwrap();
        println!("{:?}", &data);
        let tst_again: Wat = from_str(data.as_str()).unwrap();
        assert_eq!(&tst, &tst_again);
    }

    #[test]  // This works
    fn round_trip_enum_any() {
        let tst = Wat2 { wat: WatEnum::Bar };
        let data = to_string(&tst).unwrap();
        println!("{:?}", &data);
        let tst_again: Wat2 = from_str(data.as_str()).unwrap();
        assert_eq!(&tst, &tst_again);
    }
 
    #[test]  // this works
    fn round_trip_enum_text() {
        let tst = Wat3 { wat: WatEnum::Bar };
        let data = to_string(&tst).unwrap();
        println!("{:?}", &data);
        let tst_again: Wat3 = from_str(data.as_str()).unwrap();
        assert_eq!(&tst, &tst_again);
    }
}

src/escapei.rs

README.md

Changelog.md

src/se/mod.rs

dralley · 2022-10-08T04:33:45Z

Have you run benchmarks before and after?

Mingun · 2022-10-08T06:52:45Z

@dralley, no. The goal is to make a correct and consistent implementation first. There a no reason to worry about performance while the old implementation is just incorrect and inconsistent

Mingun · 2022-10-08T07:08:50Z

It appears that the #text or #any attributes are required if you want to successfully deserialize an enum from a struct.

While in this PR this can be true, that is not desired behavior. This PR is just about serializer, I plan to continue work on deserializer part in next PRs. The final goal -- a consistent and composable implementation:

consistent: the same types should be serialized and deserialized similarly independently of their location in the XML. The change of representation should depend only on explicitly added attributes in Rust code, not of a way, how types are composed
composable: if type A includes in type B, then in XML representation markup for type A should be included in markup of type B following by predictable rules
the most used patterns should be covered without (or with minimal) additional attributes. The such patterns are:
- elements and attributes
- XML xs:choice mapped to Rust enum
- text content of nodes
- deserialization with deserialize_any should give a result that close to result of converting XML to JSON (because internally serde uses JSON-like type model). This is important, because in many cases serde uses deserialize_any under the hood

dralley · 2022-10-08T17:19:21Z

There a no reason to worry about performance while the old implementation is just incorrect and inconsistent

I'm not worried about performance, correctness is of course more important, it would just be good to know if it deserves some attention afterwards

Changelog.md

src/se/content.rs

- `$text` serialized as a simple type - `$value` serialized as an element with name that depends from value instead of key - Text or CDATA elements deserialized as `$value` field, if that field is expected, and as `#text` field, if not expected - any not-listed in known fields elements deserialized as a `$value` field, if that field is expected doc-test failures (2): src\de\mod.rs - de (line 139) src\de\mod.rs - de (line 36) Co-authored-by: Daniel Alley <[email protected]>

…tafia#252 Still 2 doc-test failures

Still 2 doc-test failures

Serialization to attributes would be done only when field explicitly marked as an attribute failures (21): with_root::enum_::adjacently_tagged::flatten_struct with_root::enum_::adjacently_tagged::nested_struct with_root::enum_::adjacently_tagged::newtype with_root::enum_::adjacently_tagged::struct_ with_root::enum_::adjacently_tagged::text with_root::enum_::adjacently_tagged::tuple_struct with_root::enum_::adjacently_tagged::unit with_root::enum_::externally_tagged::nested_struct with_root::enum_::externally_tagged::struct_ with_root::enum_::externally_tagged::text with_root::enum_::internally_tagged::nested_struct with_root::enum_::internally_tagged::newtype with_root::enum_::internally_tagged::struct_ with_root::enum_::internally_tagged::text with_root::enum_::internally_tagged::unit with_root::enum_::untagged::nested_struct with_root::enum_::untagged::struct_ with_root::enum_::untagged::text with_root::nested_struct with_root::struct_ with_root::text

This commit changes expectations from serializing primitives - they should be wrapped in root tag failures (53): with_root::char_amp with_root::char_apos with_root::char_gt with_root::char_lt with_root::char_non_escaped with_root::char_quot with_root::char_space with_root::enum_::adjacently_tagged::flatten_struct with_root::enum_::adjacently_tagged::nested_struct with_root::enum_::adjacently_tagged::newtype with_root::enum_::adjacently_tagged::struct_ with_root::enum_::adjacently_tagged::text with_root::enum_::adjacently_tagged::tuple_struct with_root::enum_::adjacently_tagged::unit with_root::enum_::externally_tagged::nested_struct with_root::enum_::externally_tagged::primitive_unit with_root::enum_::externally_tagged::struct_ with_root::enum_::externally_tagged::text with_root::enum_::internally_tagged::nested_struct with_root::enum_::internally_tagged::newtype with_root::enum_::internally_tagged::struct_ with_root::enum_::internally_tagged::text with_root::enum_::internally_tagged::unit with_root::enum_::untagged::nested_struct with_root::enum_::untagged::newtype with_root::enum_::untagged::struct_ with_root::enum_::untagged::text with_root::enum_::untagged::unit with_root::f32_ with_root::f64_ with_root::false_ with_root::i128_ with_root::i16_ with_root::i32_ with_root::i64_ with_root::i8_ with_root::isize_ with_root::map with_root::nested_struct with_root::option_some with_root::seq with_root::str_escaped with_root::str_non_escaped with_root::struct_ with_root::text with_root::true_ with_root::u128_ with_root::u16_ with_root::u32_ with_root::u64_ with_root::u8_ with_root::unit with_root::usize_

… specified Now serializer tested in both modes: with and without root tag specified failures (114): with_root::char_amp with_root::char_apos with_root::char_gt with_root::char_lt with_root::char_non_escaped with_root::char_quot with_root::char_space with_root::enum_::adjacently_tagged::empty_struct with_root::enum_::adjacently_tagged::flatten_struct with_root::enum_::adjacently_tagged::nested_struct with_root::enum_::adjacently_tagged::newtype with_root::enum_::adjacently_tagged::struct_ with_root::enum_::adjacently_tagged::text with_root::enum_::adjacently_tagged::tuple_struct with_root::enum_::adjacently_tagged::unit with_root::enum_::externally_tagged::nested_struct with_root::enum_::externally_tagged::primitive_unit with_root::enum_::externally_tagged::struct_ with_root::enum_::externally_tagged::text with_root::enum_::internally_tagged::empty_struct with_root::enum_::internally_tagged::nested_struct with_root::enum_::internally_tagged::newtype with_root::enum_::internally_tagged::struct_ with_root::enum_::internally_tagged::text with_root::enum_::internally_tagged::unit with_root::enum_::untagged::nested_struct with_root::enum_::untagged::newtype with_root::enum_::untagged::struct_ with_root::enum_::untagged::text with_root::enum_::untagged::unit with_root::f32_ with_root::f64_ with_root::false_ with_root::i128_ with_root::i16_ with_root::i32_ with_root::i64_ with_root::i8_ with_root::isize_ with_root::map with_root::nested_struct with_root::option_some with_root::seq with_root::str_escaped with_root::str_non_escaped with_root::struct_ with_root::text with_root::true_ with_root::u128_ with_root::u16_ with_root::u32_ with_root::u64_ with_root::u8_ with_root::unit with_root::usize_ without_root::char_amp without_root::char_apos without_root::char_gt without_root::char_lt without_root::char_non_escaped without_root::char_quot without_root::char_space without_root::enum_::adjacently_tagged::empty_struct without_root::enum_::adjacently_tagged::flatten_struct without_root::enum_::adjacently_tagged::nested_struct without_root::enum_::adjacently_tagged::newtype without_root::enum_::adjacently_tagged::struct_ without_root::enum_::adjacently_tagged::text without_root::enum_::adjacently_tagged::tuple_struct without_root::enum_::adjacently_tagged::unit without_root::enum_::externally_tagged::nested_struct without_root::enum_::externally_tagged::primitive_unit without_root::enum_::externally_tagged::struct_ without_root::enum_::externally_tagged::text without_root::enum_::internally_tagged::empty_struct without_root::enum_::internally_tagged::flatten_struct without_root::enum_::internally_tagged::nested_struct without_root::enum_::internally_tagged::newtype without_root::enum_::internally_tagged::struct_ without_root::enum_::internally_tagged::text without_root::enum_::internally_tagged::unit without_root::enum_::untagged::flatten_struct without_root::enum_::untagged::nested_struct without_root::enum_::untagged::newtype without_root::enum_::untagged::struct_ without_root::enum_::untagged::text without_root::enum_::untagged::tuple_struct without_root::enum_::untagged::unit without_root::f32_ without_root::f64_ without_root::false_ without_root::flatten_struct without_root::i128_ without_root::i16_ without_root::i32_ without_root::i64_ without_root::i8_ without_root::isize_ without_root::map without_root::nested_struct without_root::seq without_root::str_escaped without_root::str_non_escaped without_root::struct_ without_root::text without_root::true_ without_root::tuple without_root::u128_ without_root::u16_ without_root::u32_ without_root::u64_ without_root::u8_ without_root::unit without_root::usize_

- serialize_bool - duplicate of `without_root::false_` and `without_root::true_` - serialize_struct - duplicate of `without_root::struct_` - serialize_struct_value_number - duplicate of `without_root::value` - serialize_struct_value_string - excess test, duplicate of previous - serialize_enum - duplicate of `without_root::enum_::externally_tagged::newtype` - serialize_a_list - non working test that replaced by `without_root::seq` - test_empty - duplicate of `without_root::empty_struct` - test_nested - duplicate of `without_root::nested_struct` Still 114 failures

Fixes tafia#252 Fixes tafia#280 Fixes tafia#287 Fixes tafia#343 Fixes tafia#346 Fixes tafia#361 Partially addresses tafia#368 Fixes tafia#429 Fixes tafia#430 Fixes all tests Co-authored-by: Daniel Alley <[email protected]>

failures (40): enum_::adjacently_tagged::flatten_struct::attributes enum_::adjacently_tagged::nested_struct::attributes enum_::adjacently_tagged::newtype::attributes enum_::adjacently_tagged::struct_::attributes enum_::adjacently_tagged::unit::attributes enum_::externally_tagged::flatten_struct::attributes enum_::externally_tagged::nested_struct::attributes enum_::externally_tagged::struct_::attributes enum_::internally_tagged::flatten_struct::attributes enum_::internally_tagged::nested_struct::attributes enum_::internally_tagged::struct_::attributes enum_::internally_tagged::unit::attributes enum_::untagged::flatten_struct::attributes enum_::untagged::nested_struct::attributes flatten_struct::attributes from_str_should_ignore_encoding nested_struct::attributes seq::fixed_name::fixed_size::list_of_struct seq::fixed_name::variable_size::list_of_struct seq::top_level::list_of_struct struct_::attribute_and_element struct_::attributes struct_::excess_attributes xml_schema_lists::attribute::bool_ xml_schema_lists::attribute::byte_buf xml_schema_lists::attribute::char_ xml_schema_lists::attribute::f32_ xml_schema_lists::attribute::f64_ xml_schema_lists::attribute::i128_ xml_schema_lists::attribute::i16_ xml_schema_lists::attribute::i32_ xml_schema_lists::attribute::i64_ xml_schema_lists::attribute::i8_ xml_schema_lists::attribute::string xml_schema_lists::attribute::u128_ xml_schema_lists::attribute::u16_ xml_schema_lists::attribute::u32_ xml_schema_lists::attribute::u64_ xml_schema_lists::attribute::u8_ xml_schema_lists::attribute::unit

seanpianka · 2022-12-12T22:53:01Z

What is #[serde(rename="#text")] and why does it make enum deserialization work? Is there any pre-existing docs that explain what this is or why it's needed?

Mingun · 2022-12-13T14:08:34Z

What is #[serde(rename="#text")] and why does it make enum deserialization work?

I not exactly understand your question. Could you expand it?

Is there any pre-existing docs that explain what this is or why it's needed?

Because this change is a part of future release (which I plan to make this year) you can find docs about it in the local copy after generating:

$env:RUSTDOCFLAGS="--cfg docs_rs"; cargo +nightly doc --all-features --open

and go to the documentation of the de module.

You also can read documentation source here:

quick-xml/src/de/mod.rs

Line 3 in e877f4f

//! # Difference between `$text` and `$value` special names

If anything is incomprehensible, feel free to ask so that we can address ambiguities before release.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [quick-xml](https://github.com/tafia/quick-xml) | dependencies | minor | `0.26.0` -> `0.27.1` | --- ### Release Notes <details> <summary>tafia/quick-xml</summary> ### [`v0.27.1`](https://github.com/tafia/quick-xml/blob/HEAD/Changelog.md#0271----2022-12-28) [Compare Source](tafia/quick-xml@v0.27.0...v0.27.1) ##### Bug Fixes - [#530]: Fix an infinite loop leading to unbounded memory consumption that occurs when skipping events on malformed XML with the `overlapped-lists` feature active. - [#530]: Fix an error in the `Deserializer::read_to_end` when `overlapped-lists` feature is active and malformed XML is parsed [#530]: tafia/quick-xml#530 ### [`v0.27.0`](https://github.com/tafia/quick-xml/blob/HEAD/Changelog.md#0270----2022-12-25) [Compare Source](tafia/quick-xml@v0.26.0...v0.27.0) ##### New Features - [#521]: Implement `Clone` for all error types. This required changing `Error::Io` to contain `Arc<std::io::Error>` instead of `std::io::Error` since `std::io::Error` does not implement `Clone`. ##### Bug Fixes - [#490]: Ensure that serialization of map keys always produces valid XML names. In particular, that means that maps with numeric and numeric-like keys (for example, `"42"`) no longer can be serialized because [XML name] cannot start from a digit - [#500]: Fix deserialization of top-level sequences of enums, like ```xml <?xml version="1.0" encoding="UTF-8"?>  <A/> <B/> <C/> ``` - [#514]: Fix wrong reporting `Error::EndEventMismatch` after disabling and enabling `.check_end_names` - [#517]: Fix swapped codes for `\r` and `\n` characters when escaping them - [#523]: Fix incorrect skipping text and CDATA content before any map-like structures in serde deserializer, like ```xml unwanted text<struct>...</struct> ``` - [#523]: Fix incorrect handling of `xs:list`s with encoded spaces: they still act as delimiters, which is confirmed also by mature XmlBeans Java library - [#473]: Fix a hidden requirement to enable serde's `derive` feature to get quick-xml's `serialize` feature for `edition = 2021` or `resolver = 2` crates ##### Misc Changes - [#490]: Removed `$unflatten=` special prefix for fields for serde (de)serializer, because: - it is useless for deserializer - serializer was rewritten and does not require it anymore This prefix allowed you to serialize struct field as an XML element and now replaced by a more thoughtful system explicitly indicating that a field should be serialized as an attribute by prepending `@` character to its name - [#490]: Removed `$primitive=` prefix. That prefix allowed you to serialize struct field as an attribute instead of an element and now replaced by a more thoughtful system explicitly indicating that a field should be serialized as an attribute by prepending `@` character to its name - [#490]: In addition to the `$value` special name for a field a new `$text` special name was added: - `$text` is used if you want to map field to text content only. No markup is expected (but text can represent a list as defined by `xs:list` type) - `$value` is used if you want to map elements with different names to one field, that should be represented either by an `enum`, or by sequence of `enum`s (`Vec`, tuple, etc.), or by string. Use it when you want to map field to any content of the field, text or markup Refer to [documentation] for details. - [#521]: MSRV bumped to 1.52. - [#473]: `serde` feature that used to make some types serializable, renamed to `serde-types` - [#528]: Added documentation for XML to `serde` mapping [#473]: tafia/quick-xml#473 [#490]: tafia/quick-xml#490 [#500]: tafia/quick-xml#500 [#514]: tafia/quick-xml#514 [#517]: tafia/quick-xml#517 [#521]: tafia/quick-xml#521 [#523]: tafia/quick-xml#523 [#528]: tafia/quick-xml#528 [XML name]: https://www.w3.org/TR/xml11/#NT-Name [documentation]: https://docs.rs/quick-xml/0.27.0/quick_xml/de/index.html#difference-between-text-and-value-special-names </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <[email protected]> Co-authored-by: crapStone <[email protected]> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1692 Reviewed-by: crapStone <[email protected]> Co-authored-by: Calciumdibromid Bot <[email protected]> Co-committed-by: Calciumdibromid Bot <[email protected]>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [quick-xml](https://github.com/tafia/quick-xml) | dependencies | minor | `0.27.1` -> `0.28.0` | --- ### Release Notes <details> <summary>tafia/quick-xml</summary> ### [`v0.28.0`](https://github.com/tafia/quick-xml/blob/HEAD/Changelog.md#0280----2023-03-13) [Compare Source](tafia/quick-xml@v0.27.1...v0.28.0) ##### New Features - [#541]: (De)serialize specially named `$text` enum variant in [externally tagged] enums to / from textual content - [#556]: `to_writer` and `to_string` now accept `?Sized` types - [#556]: Add new `to_writer_with_root` and `to_string_with_root` helper functions - [#520]: Add methods `BytesText::inplace_trim_start` and `BytesText::inplace_trim_end` to trim leading and trailing spaces from text events - [#565]: Allow deserialize special field names `$value` and `$text` into borrowed fields when use serde deserializer - [#568]: Rename `Writter::inner` into `Writter::get_mut` - [#568]: Add method `Writter::get_ref` - [#569]: Rewrite the `Reader::read_event_into_async` as an async fn, making the future `Send` if possible. - [#571]: Borrow element names (`<element>`) when deserialize with serde. This change allow to deserialize into `HashMap<&str, T>`, for example - [#573]: Add basic support for async byte writers via tokio's `AsyncWrite`. ##### Bug Fixes - [#537]: Restore ability to deserialize attributes that represents XML namespace mappings (`xmlns:xxx`) that was broken since [#490] - [#510]: Fix an error of deserialization of `Option<T>` fields where `T` is some sequence type (for example, `Vec` or tuple) - [#540]: Fix a compilation error (probably a rustc bug) in some circumstances. `Serializer::new` and `Serializer::with_root` now accepts only references to `Write`r. - [#520]: Merge consequent (delimited only by comments and processing instructions) texts and CDATA when deserialize using serde deserializer. `DeEvent::Text` and `DeEvent::CData` events was replaced by `DeEvent::Text` with merged content. The same behavior for the `Reader` does not implemented (yet?) and should be implemented manually - [#562]: Correctly set minimum required version of memchr dependency to 2.1 - [#565]: Correctly set minimum required version of tokio dependency to 1.10 - [#565]: Fix compilation error when build with serde <1.0.139 [externally tagged]: https://serde.rs/enum-representations.html#externally-tagged [#490]: tafia/quick-xml#490 [#510]: tafia/quick-xml#510 [#520]: tafia/quick-xml#520 [#537]: tafia/quick-xml#537 [#540]: tafia/quick-xml#540 [#541]: tafia/quick-xml#541 [#556]: tafia/quick-xml#556 [#562]: tafia/quick-xml#562 [#565]: tafia/quick-xml#565 [#568]: tafia/quick-xml#568 [#569]: tafia/quick-xml#569 [#571]: tafia/quick-xml#571 [#573]: tafia/quick-xml#573 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <[email protected]> Co-authored-by: crapStone <[email protected]> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1818 Reviewed-by: crapStone <[email protected]> Co-authored-by: Calciumdibromid Bot <[email protected]> Co-committed-by: Calciumdibromid Bot <[email protected]>

Mingun requested a review from dralley October 1, 2022 20:57

Mingun added bug enhancement serde Issues related to mapping from Rust types to XML arrays Issues related to mapping XML content onto arrays using serde labels Oct 1, 2022

Mingun mentioned this pull request Oct 1, 2022

Serialization of enums adds extra tags #346

Closed

dralley reviewed Oct 2, 2022

View reviewed changes

src/errors.rs Outdated Show resolved Hide resolved

dralley reviewed Oct 2, 2022

View reviewed changes

src/se/key.rs Outdated Show resolved Hide resolved

dralley reviewed Oct 2, 2022

View reviewed changes

tests/test.rs Show resolved Hide resolved

dralley reviewed Oct 2, 2022

View reviewed changes

Changelog.md Outdated Show resolved Hide resolved

This was referenced Oct 2, 2022

How to have tag on each item? #287

Closed

How to pretty-print with serde? #361

Closed

Deserializing $primitive= unit variants doesn't work correctly yet #354

Open

dralley reviewed Oct 8, 2022

View reviewed changes

src/escapei.rs Show resolved Hide resolved

dralley reviewed Oct 8, 2022

View reviewed changes

README.md Show resolved Hide resolved

dralley reviewed Oct 8, 2022

View reviewed changes

Changelog.md Outdated Show resolved Hide resolved

dralley reviewed Oct 8, 2022

View reviewed changes

src/se/mod.rs Show resolved Hide resolved

dacut mentioned this pull request Oct 8, 2022

Fix clippy issues #494

Merged

dralley reviewed Oct 10, 2022

View reviewed changes

Changelog.md Outdated Show resolved Hide resolved

dralley reviewed Oct 10, 2022

View reviewed changes

src/se/content.rs Outdated Show resolved Hide resolved

dralley reviewed Oct 10, 2022

View reviewed changes

src/se/content.rs Outdated Show resolved Hide resolved

dralley reviewed Oct 10, 2022

View reviewed changes

src/se/content.rs Outdated Show resolved Hide resolved

Mingun and others added 11 commits October 26, 2022 21:32

Implement ElementSerializer which can store object as an XML tree. Fix …

ad854e1

…tafia#252 Still 2 doc-test failures

Implement indentation for new serializer. Fix tafia#361

bd0b792

Still 2 doc-test failures

Switch to new serializer

4f376b1

Fixes tafia#252 Fixes tafia#280 Fixes tafia#287 Fixes tafia#343 Fixes tafia#346 Fixes tafia#361 Partially addresses tafia#368 Fixes tafia#429 Fixes tafia#430 Fixes all tests Co-authored-by: Daniel Alley <[email protected]>

Add tests for indentation

58924da

Implement special deserializer for key names

8b50c64

Mingun force-pushed the ser branch from af6f35c to 8b50c64 Compare October 26, 2022 17:16

Mingun merged commit 0c6eeb0 into tafia:master Oct 26, 2022

Mingun deleted the ser branch October 26, 2022 17:41

This was referenced Oct 29, 2022

Fix serialization of structs #205

Closed

Nested Struct and Enum Serialization #183

Closed

Using flatten and rename="$value" on adjacent fields causes error #326

Open

Mingun mentioned this pull request Nov 13, 2022

Add additional tests for borrowed input #509

Merged

sandersantema mentioned this pull request Nov 15, 2022

[Question]: Deserialize optional vector #510

Closed

Mingun mentioned this pull request Dec 2, 2022

How to serializing Option<String> to self close element with #[serde(rename = "$unflatten={}")] #518

Closed

ghost mentioned this pull request Jan 4, 2023

Serialization of Option<String> = None, old behaviour still possible? #536

Closed

Mingun mentioned this pull request Jan 6, 2023

Restore ability to deserialize attributes that represents XML namespace mappings (xmlns:xxx) #539

Merged

spazm mentioned this pull request Feb 20, 2023

Breaking change to deserialization in 0.27.0 - Err value: Custom("missing field ...") #558

Closed

Mingun mentioned this pull request Sep 9, 2023

Fix benchmarks in compare project #644

Merged

Mingun mentioned this pull request Sep 19, 2023

serde deserialize, attribute and child element share the same name #293

Closed

ginglis13 mentioned this pull request Jul 23, 2024

quick-xml update breaks netdog XML serialization bottlerocket-os/bottlerocket-core-kit#47

Closed

Comments

Conversation

Mingun commented Oct 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Oct 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dralley commented Oct 2, 2022

Uh oh!

rrichardson commented Oct 7, 2022

Uh oh!

rrichardson commented Oct 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dralley commented Oct 8, 2022

Uh oh!

Mingun commented Oct 8, 2022

Uh oh!

Mingun commented Oct 8, 2022

Uh oh!

dralley commented Oct 8, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

seanpianka commented Dec 12, 2022

Uh oh!

Mingun commented Dec 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Mingun commented Oct 1, 2022 •

edited

Loading

codecov-commenter commented Oct 1, 2022 •

edited

Loading

rrichardson commented Oct 7, 2022 •

edited

Loading