Skip to content

Add Support my work section#169

Merged
szepeviktor merged 2 commits intomasterfrom
szepeviktor-patch-1
Mar 5, 2023
Merged

Add Support my work section#169
szepeviktor merged 2 commits intomasterfrom
szepeviktor-patch-1

Conversation

@szepeviktor
Copy link
Copy Markdown
Owner

@szepeviktor szepeviktor commented Mar 2, 2023 •
edited
Loading

👀
https://github.com/szepeviktor/phpstan-wordpress/blob/szepeviktor-patch-1/README.md#support-my-work
@adamlaki There seems to be a color difference and this heart does not beat :(

What if we add the same ids/classes -> then GitHub's CSS will work on our svg too?

@szepeviktor szepeviktor self-assigned this Mar 2, 2023
@szepeviktor szepeviktor merged commit a49f83b into master Mar 5, 2023
@szepeviktor szepeviktor deleted the szepeviktor-patch-1 branch March 5, 2023 10:16
@adamlaki
Copy link
Copy Markdown

adamlaki commented Mar 5, 2023

Viktor,

you asked this via e-mail; why didn't you continue the discussion over there?

Please, don't give half the information. If a color does not match, what color is it?

What kind of animation do you want, just on the hover state (like the button)?

@szepeviktor
Copy link
Copy Markdown
Owner Author

szepeviktor commented Mar 5, 2023

Please, don't give half the information. If a color does not match, what color is it?

I'm sorry.
This PR fixes the color. szepeviktor/.github#1
Could you approve it?

What kind of animation do you want, just on the hover state (like the button)?

Yes, hover-only animation.
Is that possible in SVG?
This button is used in README-s.

@adamlaki
Copy link
Copy Markdown

adamlaki commented Mar 5, 2023

I've approved it, looks good.

Yes, in theory, it is possible. I will make the addition soon.

@adamlaki
Copy link
Copy Markdown

adamlaki commented Mar 5, 2023

I don't understand where the color diff is coming from; it is correct in the file that I sent you.

@szepeviktor
Copy link
Copy Markdown
Owner Author

szepeviktor commented Mar 5, 2023 •
edited
Loading

I've added some SVG features and optimization.

    <rect width="92" height="28" ...
    <path fill="#BF3989" ...
    <text ...

Add messed up the color code ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@szepeviktor szepeviktor

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@szepeviktor @adamlaki