Replace deprecated $type instanceof ConstantStringType#150
Merged
szepeviktor merged 7 commits intoszepeviktor:masterfrom Feb 24, 2023
Merged
Replace deprecated $type instanceof ConstantStringType#150szepeviktor merged 7 commits intoszepeviktor:masterfrom
$type instanceof ConstantStringType#150szepeviktor merged 7 commits intoszepeviktor:masterfrom
Conversation
Owner
|
Ian, this is like a gift to me. Thank you. |
Contributor
|
👍 |
Contributor
|
And this also gives us support for more union type scenarios as discussed recently. Thx! I also had this on my list but didn't find time yet :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces some of the deprecated
$type instanceof ConstantStringTypebyas suggested in Why Is instanceof *Type Wrong and Getting Deprecated?.
Part of #149