Add dynamic return type extension for wp_tag_cloud()#147
Closed
IanDelMar wants to merge 4 commits intoszepeviktor:masterfrom
Closed
Add dynamic return type extension for wp_tag_cloud()#147IanDelMar wants to merge 4 commits intoszepeviktor:masterfrom
wp_tag_cloud()#147IanDelMar wants to merge 4 commits intoszepeviktor:masterfrom
Conversation
Contributor
Author
|
I'll have a look at the failed checks tomorrow. |
Contributor
|
Jfyi I think we need to be careful to not introduce too many instanceof checks, see also https://phpstan.org/blog/why-is-instanceof-type-wrong-and-getting-deprecated :) But don't let this block you here, maybe for the next PR. We can try to refactor some away later |
Contributor
Author
|
@herndlm Thank you! I wasn't aware of that. |
IanDelMar
changed the title
wp_tag_cloud()
szepeviktor
reviewed
Jul 27, 2023
szepeviktor
reviewed
Jul 27, 2023
IanDelMar
force-pushed
the
wp-tag-cloud
branch
from
459ee03 to
7b197e1
Compare
Contributor
Author
|
Implemented in stubs #147 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a dynamic function return type extension for
wp_tag_cloud().I have made several updates to the extension since the initial draft:
instanceofhas been removed.