Skip to content

Fix return type of the_title() and single_month_title()#145

Merged
szepeviktor merged 3 commits intoszepeviktor:masterfrom
IanDelMar:fix-echo-param
Feb 8, 2023
Merged

Fix return type of the_title() and single_month_title()#145
szepeviktor merged 3 commits intoszepeviktor:masterfrom
IanDelMar:fix-echo-param

Conversation

@IanDelMar
Copy link
Copy Markdown
Contributor

This PR fixes the return types for the_title() and single_month_title() in EchoParameterDynamicFunctionReturnTypeExtension.

I forgot to add the other types in #111 and #143.

Comment thread src/EchoParameterDynamicFunctionReturnTypeExtension.php Outdated
Comment thread src/EchoParameterDynamicFunctionReturnTypeExtension.php Outdated
Co-authored-by: Viktor Szépe <[email protected]>
Comment thread src/EchoParameterDynamicFunctionReturnTypeExtension.php Outdated
@szepeviktor
Copy link
Copy Markdown
Owner

@johnbillion Do you have any comments?

Copy link
Copy Markdown
Contributor

@johnbillion johnbillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches.

@szepeviktor szepeviktor merged commit 927c0f1 into szepeviktor:master Feb 8, 2023
@IanDelMar IanDelMar deleted the fix-echo-param branch February 9, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants