Fix return type of the_title() and single_month_title()#145
Merged
szepeviktor merged 3 commits intoszepeviktor:masterfrom Feb 8, 2023
Merged
Fix return type of the_title() and single_month_title()#145szepeviktor merged 3 commits intoszepeviktor:masterfrom
szepeviktor merged 3 commits intoszepeviktor:masterfrom
Conversation
szepeviktor
reviewed
Feb 8, 2023
szepeviktor
reviewed
Feb 8, 2023
Co-authored-by: Viktor Szépe <[email protected]>
szepeviktor
reviewed
Feb 8, 2023
Owner
|
@johnbillion Do you have any comments? |
szepeviktor
approved these changes
Feb 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the return types for
the_title()andsingle_month_title()inEchoParameterDynamicFunctionReturnTypeExtension.I forgot to add the other types in #111 and #143.