refactor: remove ConnectionCodec and use lazy pool creation #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsert plans - Change RemoteTableScanExec and RemoteTableInsertExec to hold Option<Arc<dyn Pool>> instead of Arc<dyn Connection> - Create pool lazily during execute() when pool is None - Remove ConnectionCodec trait and DefaultConnectionCodec - Remove connection_codec field from RemotePhysicalCodec - This eliminates block_in_place during codec decode, improving async compatibility
…ching - Remove 'connection' field from RemoteTableScanExec and RemoteTableInsertExec proto messages - Change pool field type from Option<Arc<dyn Pool>> to Arc<Mutex<Option<Arc<dyn Pool>>>> - Pool is created lazily on first use and cached in the Mutex for subsequent reuse - Add get_or_create_pool helper function for thread-safe lazy initialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the scan and insert execution plans to eliminate
block_in_placecalls during codec decode.Changes
Arc<dyn Connection>toOption<Arc<dyn Pool>>poolisNone(e.g., after deserialization), the pool is created lazily duringexecute()ConnectionCodectrait andDefaultConnectionCodecimplementation are no longer neededconnection_codecfieldBenefits
block_in_placeduring codec decode, improving async compatibility